From ead91455d81f679b4d75d84d705859e5fa5b2f37 Mon Sep 17 00:00:00 2001 From: yiling Date: Wed, 17 Jun 2026 21:51:34 +0800 Subject: [PATCH 1/3] feat(api): implement read-only mode for reviewers controlled by REVIEWER_READ_ONLY env --- packages/api/src/middleware/auth.test.ts | 111 +++++++++++++++++++++++ packages/api/src/middleware/auth.ts | 17 ++++ 2 files changed, 128 insertions(+) create mode 100644 packages/api/src/middleware/auth.test.ts diff --git a/packages/api/src/middleware/auth.test.ts b/packages/api/src/middleware/auth.test.ts new file mode 100644 index 00000000..2756834b --- /dev/null +++ b/packages/api/src/middleware/auth.test.ts @@ -0,0 +1,111 @@ +import { describe, expect, it, vi, beforeEach } from 'vitest' +import { Hono } from 'hono' +import { authMiddleware } from './auth' +import { auth } from '@shumai/core/src/auth/auth' +import { prisma } from '@shumai/db' + +vi.mock('@shumai/core/src/auth/auth', () => ({ + auth: { + api: { + getSession: vi.fn(), + }, + }, +})) + +vi.mock('@shumai/db', () => ({ + prisma: { + user: { + findUnique: vi.fn(), + }, + teamMember: { + findFirst: vi.fn(), + }, + }, +})) + +describe('authMiddleware', () => { + const app = new Hono() + .use('*', authMiddleware) + .get('/test', (c) => c.text('ok')) + .post('/test', (c) => c.text('ok')) + + beforeEach(() => { + vi.resetAllMocks() + delete process.env.REVIEWER_READ_ONLY + }) + + it('allows access when authenticated', async () => { + // eslint-disable-next-line @typescript-eslint/no-explicit-any + vi.mocked(auth.api.getSession).mockResolvedValue({ user: { id: 'user1' } } as any) + // eslint-disable-next-line @typescript-eslint/no-explicit-any + vi.mocked(prisma.user.findUnique).mockResolvedValue({ id: 'user1' } as any) + + const res = await app.request('/test') + expect(res.status).toBe(200) + }) + + it('rejects when not authenticated', async () => { + vi.mocked(auth.api.getSession).mockResolvedValue(null) + + const res = await app.request('/test') + expect(res.status).toBe(401) + }) + + describe('read-only mode', () => { + beforeEach(() => { + process.env.REVIEWER_READ_ONLY = '1' + }) + + it('allows GET for reviewer', async () => { + // eslint-disable-next-line @typescript-eslint/no-explicit-any + vi.mocked(auth.api.getSession).mockResolvedValue({ user: { id: 'user1' } } as any) + // eslint-disable-next-line @typescript-eslint/no-explicit-any + vi.mocked(prisma.user.findUnique).mockResolvedValue({ id: 'user1' } as any) + + const res = await app.request('/test') + expect(res.status).toBe(200) + }) + + it('rejects POST for reviewer', async () => { + // eslint-disable-next-line @typescript-eslint/no-explicit-any + vi.mocked(auth.api.getSession).mockResolvedValue({ user: { id: 'user1' } } as any) + // eslint-disable-next-line @typescript-eslint/no-explicit-any + vi.mocked(prisma.user.findUnique).mockResolvedValue({ id: 'user1' } as any) + vi.mocked(prisma.teamMember.findFirst).mockResolvedValue(null) // No owner/editor role + + const res = await app.request('/test', { method: 'POST' }) + expect(res.status).toBe(403) + expect(await res.json()).toEqual({ error: 'System is in read-only mode' }) + }) + + it('allows POST for owner', async () => { + // eslint-disable-next-line @typescript-eslint/no-explicit-any + vi.mocked(auth.api.getSession).mockResolvedValue({ user: { id: 'user1' } } as any) + // eslint-disable-next-line @typescript-eslint/no-explicit-any + vi.mocked(prisma.user.findUnique).mockResolvedValue({ id: 'user1' } as any) + // eslint-disable-next-line @typescript-eslint/no-explicit-any + vi.mocked(prisma.teamMember.findFirst).mockResolvedValue({ + id: 'member1', + role: 'owner', + } as any) + + const res = await app.request('/test', { method: 'POST' }) + expect(res.status).toBe(200) + }) + + it('allows POST for editor', async () => { + // eslint-disable-next-line @typescript-eslint/no-explicit-any + vi.mocked(auth.api.getSession).mockResolvedValue({ user: { id: 'user1' } } as any) + // eslint-disable-next-line @typescript-eslint/no-explicit-any + vi.mocked(prisma.user.findUnique).mockResolvedValue({ id: 'user1' } as any) + // eslint-disable-next-line @typescript-eslint/no-explicit-any + vi.mocked(prisma.teamMember.findFirst).mockResolvedValue({ + id: 'member1', + role: 'editor', + } as any) + + const res = await app.request('/test', { method: 'POST' }) + expect(res.status).toBe(200) + }) + }) +}) diff --git a/packages/api/src/middleware/auth.ts b/packages/api/src/middleware/auth.ts index 9a8c7b1f..77649968 100644 --- a/packages/api/src/middleware/auth.ts +++ b/packages/api/src/middleware/auth.ts @@ -28,6 +28,23 @@ export const authMiddleware = createMiddleware<{ } c.set('user', user) + + if (process.env.REVIEWER_READ_ONLY === '1') { + const method = c.req.method.toUpperCase() + if (['POST', 'PUT', 'PATCH', 'DELETE'].includes(method)) { + const member = await prisma.teamMember.findFirst({ + where: { + userId: user.id, + role: { in: ['owner', 'editor'] }, + }, + }) + + if (!member) { + return c.json({ error: 'System is in read-only mode' }, 403) + } + } + } + await next() } catch { return c.json({ error: 'Authentication failed' }, 401) From d81fc275f4e5d9a5bd7459e488702819fe6936d1 Mon Sep 17 00:00:00 2001 From: yiling Date: Wed, 17 Jun 2026 22:19:44 +0800 Subject: [PATCH 2/3] fix(api): correct lint errors in authMiddleware tests --- packages/api/src/middleware/auth.test.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/api/src/middleware/auth.test.ts b/packages/api/src/middleware/auth.test.ts index 2756834b..099f210b 100644 --- a/packages/api/src/middleware/auth.test.ts +++ b/packages/api/src/middleware/auth.test.ts @@ -83,10 +83,10 @@ describe('authMiddleware', () => { vi.mocked(auth.api.getSession).mockResolvedValue({ user: { id: 'user1' } } as any) // eslint-disable-next-line @typescript-eslint/no-explicit-any vi.mocked(prisma.user.findUnique).mockResolvedValue({ id: 'user1' } as any) - // eslint-disable-next-line @typescript-eslint/no-explicit-any vi.mocked(prisma.teamMember.findFirst).mockResolvedValue({ id: 'member1', role: 'owner', + // eslint-disable-next-line @typescript-eslint/no-explicit-any } as any) const res = await app.request('/test', { method: 'POST' }) @@ -98,10 +98,10 @@ describe('authMiddleware', () => { vi.mocked(auth.api.getSession).mockResolvedValue({ user: { id: 'user1' } } as any) // eslint-disable-next-line @typescript-eslint/no-explicit-any vi.mocked(prisma.user.findUnique).mockResolvedValue({ id: 'user1' } as any) - // eslint-disable-next-line @typescript-eslint/no-explicit-any vi.mocked(prisma.teamMember.findFirst).mockResolvedValue({ id: 'member1', role: 'editor', + // eslint-disable-next-line @typescript-eslint/no-explicit-any } as any) const res = await app.request('/test', { method: 'POST' }) From f4276a19aa451a23963af4b33d033f8af4dd13aa Mon Sep 17 00:00:00 2001 From: yiling Date: Wed, 17 Jun 2026 22:30:09 +0800 Subject: [PATCH 3/3] feat(api): allow search API in read-only mode --- packages/api/src/middleware/auth.test.ts | 11 +++++++++++ packages/api/src/middleware/auth.ts | 3 ++- 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/packages/api/src/middleware/auth.test.ts b/packages/api/src/middleware/auth.test.ts index 099f210b..6d48bcc4 100644 --- a/packages/api/src/middleware/auth.test.ts +++ b/packages/api/src/middleware/auth.test.ts @@ -28,6 +28,7 @@ describe('authMiddleware', () => { .use('*', authMiddleware) .get('/test', (c) => c.text('ok')) .post('/test', (c) => c.text('ok')) + .post('/test/search', (c) => c.text('ok')) beforeEach(() => { vi.resetAllMocks() @@ -78,6 +79,16 @@ describe('authMiddleware', () => { expect(await res.json()).toEqual({ error: 'System is in read-only mode' }) }) + it('allows POST /search for reviewer', async () => { + // eslint-disable-next-line @typescript-eslint/no-explicit-any + vi.mocked(auth.api.getSession).mockResolvedValue({ user: { id: 'user1' } } as any) + // eslint-disable-next-line @typescript-eslint/no-explicit-any + vi.mocked(prisma.user.findUnique).mockResolvedValue({ id: 'user1' } as any) + + const res = await app.request('/test/search', { method: 'POST' }) + expect(res.status).toBe(200) + }) + it('allows POST for owner', async () => { // eslint-disable-next-line @typescript-eslint/no-explicit-any vi.mocked(auth.api.getSession).mockResolvedValue({ user: { id: 'user1' } } as any) diff --git a/packages/api/src/middleware/auth.ts b/packages/api/src/middleware/auth.ts index 77649968..c0ac0278 100644 --- a/packages/api/src/middleware/auth.ts +++ b/packages/api/src/middleware/auth.ts @@ -31,7 +31,8 @@ export const authMiddleware = createMiddleware<{ if (process.env.REVIEWER_READ_ONLY === '1') { const method = c.req.method.toUpperCase() - if (['POST', 'PUT', 'PATCH', 'DELETE'].includes(method)) { + const path = c.req.path + if (['POST', 'PUT', 'PATCH', 'DELETE'].includes(method) && !path.endsWith('/search')) { const member = await prisma.teamMember.findFirst({ where: { userId: user.id,