diff --git a/CHANGELOG.md b/CHANGELOG.md index cd3743c3..2f80e301 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -15,6 +15,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/). ### Changed +* **search**: Display search results in a responsive card grid with interactive hover video sprite scrubbing, semantic match chunk time range previews, and new-tab opening on click * **search**: Significantly improve semantic search response times by generating query text embeddings directly with in-memory caching instead of dispatching background tasks ## [0.5.2] - 2026-10-13 diff --git a/packages/webui/components/file-browser/file-card.test.tsx b/packages/webui/components/file-browser/file-card.test.tsx index 0f738cd1..c9a335af 100644 --- a/packages/webui/components/file-browser/file-card.test.tsx +++ b/packages/webui/components/file-browser/file-card.test.tsx @@ -441,4 +441,39 @@ describe('FileCard', () => { expect(tooltip.textContent).toContain('FFmpeg transcode failed: exit code 1') vi.useRealTimers() }) + + it('does not render selection checkbox when hideCheckbox is true', () => { + renderComponent({ item: fileItem, hideCheckbox: true }) + expect(screen.queryByRole('checkbox')).toBeNull() + }) + + it('renders selection checkbox by default when hideCheckbox is false or omitted', () => { + renderComponent({ item: fileItem }) + expect(screen.getByRole('checkbox')).toBeTruthy() + }) + + it('does not render 3-dot dropdown menu when hideActions is true', () => { + renderComponent({ item: fileItem, hideActions: true }) + // No dropdown trigger button rendered + expect(screen.queryByRole('button')).toBeNull() + }) + + it('renders matched duration chunk in preview when startTime and endTime are present', () => { + const videoWithMatch: AssetInfo = { + ...fileItem, + startTime: 65, + endTime: 125, + preview: { + proxyType: 'video', + thumbnailUrl: 'https://example.com/poster.webp', + duration: 300, + }, + } as AssetInfo + + renderComponent({ item: videoWithMatch }) + + const matchedDuration = screen.getByTestId('file-preview-matched-duration') + expect(matchedDuration).toBeTruthy() + expect(matchedDuration.textContent).toBe('01:05 - 02:05') + }) }) diff --git a/packages/webui/components/file-browser/file-card.tsx b/packages/webui/components/file-browser/file-card.tsx index a2e5da03..a32156e4 100644 --- a/packages/webui/components/file-browser/file-card.tsx +++ b/packages/webui/components/file-browser/file-card.tsx @@ -48,18 +48,18 @@ import { FIELD_TYPE_ICONS } from '../fields-manager' interface FileCardProps { teamId?: string item: AssetInfo - isSelected: boolean - isChecked: boolean - isEditing: boolean - onSelect: (item: AssetInfo, event: React.MouseEvent) => void - onDoubleClick: (item: AssetInfo) => void - onContextMenu: (e: React.MouseEvent, item: AssetInfo) => void + isSelected?: boolean + isChecked?: boolean + isEditing?: boolean + onSelect?: (item: AssetInfo, event: React.MouseEvent) => void + onDoubleClick?: (item: AssetInfo) => void + onContextMenu?: (e: React.MouseEvent, item: AssetInfo) => void // Deprecated manual drag handlers replaced by dnd-kit - onDragStart: (item: AssetInfo) => void - onDrop: (target: AssetInfo) => void - onRename: (newName: string) => void - onFinishEditing: () => void - onSaveField: (fieldId: string, value: unknown) => void + onDragStart?: (item: AssetInfo) => void + onDrop?: (target: AssetInfo) => void + onRename?: (newName: string) => void + onFinishEditing?: () => void + onSaveField?: (fieldId: string, value: unknown) => void dragState?: DragState disabled?: boolean onAction?: ( @@ -69,39 +69,43 @@ interface FileCardProps { isRecentlyDeleted?: boolean isRecents?: boolean selectedCount?: number - fields: MetadataFieldInfo[] + fields?: MetadataFieldInfo[] isShareView?: boolean canEdit?: boolean /** When false, hides the download action. Defaults to true. */ allowDownload?: boolean + hideCheckbox?: boolean + hideActions?: boolean } export function FileCard({ teamId, item, - isSelected, - isChecked, - isEditing, - onSelect, - onDoubleClick, - onContextMenu, + isSelected = false, + isChecked = false, + isEditing = false, + onSelect = () => {}, + onDoubleClick = () => {}, + onContextMenu = () => {}, // eslint-disable-next-line @typescript-eslint/no-unused-vars onDragStart: _onDragStart, // eslint-disable-next-line @typescript-eslint/no-unused-vars onDrop: _onDrop, - onRename, - onFinishEditing, - onSaveField, + onRename = () => {}, + onFinishEditing = () => {}, + onSaveField = () => {}, dragState, disabled, onAction, isRecentlyDeleted, isRecents, selectedCount, - fields, + fields = [], isShareView, canEdit = true, allowDownload = true, + hideCheckbox = false, + hideActions = false, }: FileCardProps) { const [name, setName] = useState(item.name) const inputRef = useRef(null) @@ -170,10 +174,12 @@ export function FileCard({ id: displayItem.id, item: displayItem, }, + disabled: disabled, }) // Combine refs const setNodeRef = (node: HTMLElement | null) => { + if (disabled) return setDraggableRef(node) setDroppableRef(node) } @@ -332,17 +338,19 @@ export function FileCard({ showDropFeedback && 'border-primary outline-1 outline-primary', )} > -
- {}} - onClick={(e) => { - e.stopPropagation() - onSelect(displayItem, e) - }} - className="h-4 w-4 bg-white/20 dark:bg-white/20 border-2 data-[state=checked]:bg-primary data-[state=checked]:border-primary border-foreground/15" - /> -
+ {!hideCheckbox && ( +
+ {}} + onClick={(e) => { + e.stopPropagation() + onSelect(displayItem, e) + }} + className="h-4 w-4 bg-white/20 dark:bg-white/20 border-2 data-[state=checked]:bg-primary data-[state=checked]:border-primary border-foreground/15" + /> +
+ )}
{displayItem.agent && ( @@ -395,7 +403,15 @@ export function FileCard({ data-testid="file-card-preview-media" className={cn('h-full w-full', isProcessing && 'animate-pulse')} > - +
{previewBadges} @@ -435,7 +451,15 @@ export function FileCard({ ) : ( <> - + {previewBadges} )} @@ -487,7 +511,7 @@ export function FileCard({ - {!isRecents && ( + {!hideActions && !isRecents && (