From 11d21444cff85d1613f79723e080a026ae5584eb Mon Sep 17 00:00:00 2001 From: Yiling-J Date: Tue, 29 Sep 2026 10:40:13 +0800 Subject: [PATCH] fix(trash): prevent empty trash dialog from closing before API call completes (#434) AlertDialogAction from Radix UI auto-closes the dialog on click. Added e.preventDefault() so the dialog stays open and shows the 'Deleting...' loading state until the operation finishes. Fixes both desktop and mobile file browsers. --- CHANGELOG.md | 2 ++ packages/webui/components/file-browser/file-browser.tsx | 3 ++- .../webui/components/file-browser/mobile-file-browser.tsx | 5 ++++- 3 files changed, 8 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index d75e8be2..6cb72c45 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -10,6 +10,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/). ### Fixed +- **trash**: Fix an issue where the "Empty Trash" confirmation dialog would close immediately instead of showing a loading state while files were being permanently deleted + ### Changed ## [0.4.9] - 2026-09-28 diff --git a/packages/webui/components/file-browser/file-browser.tsx b/packages/webui/components/file-browser/file-browser.tsx index db226457..7f45fdaf 100644 --- a/packages/webui/components/file-browser/file-browser.tsx +++ b/packages/webui/components/file-browser/file-browser.tsx @@ -1258,7 +1258,8 @@ export function FileBrowser({ Cancel { + onClick={(e) => { + e.preventDefault() emptyTrash() }} className="bg-destructive text-destructive-foreground hover:bg-destructive/90" diff --git a/packages/webui/components/file-browser/mobile-file-browser.tsx b/packages/webui/components/file-browser/mobile-file-browser.tsx index 73965074..086cfc3b 100644 --- a/packages/webui/components/file-browser/mobile-file-browser.tsx +++ b/packages/webui/components/file-browser/mobile-file-browser.tsx @@ -654,7 +654,10 @@ export function MobileFileBrowser({ {m.cancel()} emptyTrash()} + onClick={(e) => { + e.preventDefault() + emptyTrash() + }} className="bg-destructive text-destructive-foreground hover:bg-destructive/90" disabled={isEmptyingTrash} >