From 2aba1c898bb0dcfadff7a58b78307bf1fd25de1a Mon Sep 17 00:00:00 2001 From: yiling Date: Wed, 17 Jun 2026 16:39:23 +0800 Subject: [PATCH] feat(core): allow deleting builtin providers --- packages/core/src/provider/provider.test.ts | 8 ++++---- packages/core/src/provider/provider.ts | 4 ---- 2 files changed, 4 insertions(+), 8 deletions(-) diff --git a/packages/core/src/provider/provider.test.ts b/packages/core/src/provider/provider.test.ts index 5ae3b053..453fbce1 100644 --- a/packages/core/src/provider/provider.test.ts +++ b/packages/core/src/provider/provider.test.ts @@ -38,7 +38,7 @@ describe('ProviderService', () => { expect(providers[0].name).toBe(firstInGenerated) }) - it('should prevent deletion of builtin providers', async () => { + it('should allow deletion of builtin providers', async () => { const team = await teamService.ensureDefaultTeam() await providerService.initBuiltinProviders(team.id) @@ -46,9 +46,9 @@ describe('ProviderService', () => { const builtin = providers.find((p) => p.isBuiltin) expect(builtin).toBeDefined() - await expect(providerService.delete(team.id, builtin!.id)).rejects.toThrow( - 'Cannot delete builtin provider', - ) + await providerService.delete(team.id, builtin!.id) + const afterDelete = await providerService.listByTeam(team.id) + expect(afterDelete.find((p) => p.id === builtin!.id)).toBeUndefined() }) it('should allow editing builtin providers', async () => { diff --git a/packages/core/src/provider/provider.ts b/packages/core/src/provider/provider.ts index 3c1c255f..f072f567 100644 --- a/packages/core/src/provider/provider.ts +++ b/packages/core/src/provider/provider.ts @@ -143,10 +143,6 @@ export class ProviderService { throw new Error('Provider not found') } - if (provider.isBuiltin) { - throw new Error('Cannot delete builtin provider') - } - return this.prismaClient.provider.delete({ where: { id, teamId }, })