From 5111fcd6a5f961936e48aa889b3fa6bec99b3ba4 Mon Sep 17 00:00:00 2001 From: yiling Date: Tue, 16 Jun 2026 09:53:28 +0800 Subject: [PATCH] refactor(transcode): address code review feedback on imports and dataFormatNames typing --- packages/agent/src/activities/ai.test.ts | 2 +- packages/agent/src/activities/ai.ts | 2 +- packages/api/src/file.test.ts | 2 +- packages/api/src/file.ts | 2 +- packages/core/src/transcode/dataFormatNames.ts | 2 +- packages/transcode/src/activities/transcode.test.ts | 2 +- packages/transcode/src/activities/transcode.ts | 2 +- 7 files changed, 7 insertions(+), 7 deletions(-) diff --git a/packages/agent/src/activities/ai.test.ts b/packages/agent/src/activities/ai.test.ts index b2fb44a1..044c7223 100644 --- a/packages/agent/src/activities/ai.test.ts +++ b/packages/agent/src/activities/ai.test.ts @@ -7,7 +7,7 @@ import { saveAssetEmbeddingsActivity, } from './ai' import { s3Service } from '@shumai/core/src/s3/s3' -import { transcodeService } from '@shumai/core/src/transcode/transcode' +import { transcodeService } from '@shumai/core' import { prisma, AssetType, AssetStatus } from '@shumai/db' import { setupTestDbHooks } from '@shumai/db/test' import * as fs from 'fs' diff --git a/packages/agent/src/activities/ai.ts b/packages/agent/src/activities/ai.ts index 64938ef9..41c96d67 100644 --- a/packages/agent/src/activities/ai.ts +++ b/packages/agent/src/activities/ai.ts @@ -1,6 +1,6 @@ import { GoogleGenAI } from '@google/genai' import { s3Service } from '@shumai/core/src/s3/s3' -import { transcodeService } from '@shumai/core/src/transcode/transcode' +import { transcodeService } from '@shumai/core' import { execFile } from 'child_process' import * as fs from 'fs' import * as os from 'os' diff --git a/packages/api/src/file.test.ts b/packages/api/src/file.test.ts index 70a81a9b..3af42576 100644 --- a/packages/api/src/file.test.ts +++ b/packages/api/src/file.test.ts @@ -6,7 +6,7 @@ import { assetService } from '@shumai/core/src/asset/asset' import { metadataService } from '@shumai/core/src/metadata/metadata' import { notificationService } from '@shumai/core/src/notification/notification' import { s3Service } from '@shumai/core/src/s3/s3' -import { transcodeService } from '@shumai/core/src/transcode/transcode' +import { transcodeService } from '@shumai/core' import { authMiddleware } from './middleware/auth' import { authzService, ResourceType, Permission } from '@shumai/core/src/authz/authz' diff --git a/packages/api/src/file.ts b/packages/api/src/file.ts index cd62d1a1..43fc625b 100644 --- a/packages/api/src/file.ts +++ b/packages/api/src/file.ts @@ -17,7 +17,7 @@ import { uploadFileRequestSchema, getDownloadLinksRequestSchema, } from '@shumai/dtos' -import { transcodeService } from '@shumai/core/src/transcode/transcode' +import { transcodeService } from '@shumai/core' import fs from 'fs' import { Hono } from 'hono' import os from 'os' diff --git a/packages/core/src/transcode/dataFormatNames.ts b/packages/core/src/transcode/dataFormatNames.ts index 110469c5..71547bfb 100644 --- a/packages/core/src/transcode/dataFormatNames.ts +++ b/packages/core/src/transcode/dataFormatNames.ts @@ -1,4 +1,4 @@ -export const dataFormatNames: Record = { +export const dataFormatNames: Readonly> = { // additional codecs apch: 'Apple ProRes 422 High Quality', apcn: 'Apple ProRes 422 Standard Definition', diff --git a/packages/transcode/src/activities/transcode.test.ts b/packages/transcode/src/activities/transcode.test.ts index 4e77e0f3..83cedfb5 100644 --- a/packages/transcode/src/activities/transcode.test.ts +++ b/packages/transcode/src/activities/transcode.test.ts @@ -3,7 +3,7 @@ import { s3Service } from '@shumai/core/src/s3/s3' import { prisma } from '@shumai/db' import { setupTestDbHooks } from '@shumai/db/test' import { beforeEach, describe, expect, it, vi } from 'vitest' -import { transcodeService } from '@shumai/core/src/transcode/transcode' +import { transcodeService } from '@shumai/core' import { getMediaInfoActivity, overlayAnnotationsActivity, diff --git a/packages/transcode/src/activities/transcode.ts b/packages/transcode/src/activities/transcode.ts index 77feb76a..beb73569 100644 --- a/packages/transcode/src/activities/transcode.ts +++ b/packages/transcode/src/activities/transcode.ts @@ -1,6 +1,6 @@ import { prisma } from '@shumai/db' import { s3Service } from '@shumai/core/src/s3/s3' -import { transcodeService } from '@shumai/core/src/transcode/transcode' +import { transcodeService } from '@shumai/core' import { metadataService } from '@shumai/core/src/metadata/metadata' import { ApplicationFailure } from '@temporalio/activity' import * as path from 'path'