From 6a2cb2c8c554f759a5bc07f80b30cd6a6821389e Mon Sep 17 00:00:00 2001 From: yiling Date: Sat, 23 May 2026 23:57:46 +0800 Subject: [PATCH] refactor(asset): add cleanup job lifecycle control and ordering --- src/services/asset/asset.ts | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/src/services/asset/asset.ts b/src/services/asset/asset.ts index c8ccd5af..2db1d904 100644 --- a/src/services/asset/asset.ts +++ b/src/services/asset/asset.ts @@ -760,9 +760,14 @@ export class AssetService { } } + private cleanupJobsRunning = false + startCleanupJob() { + this.cleanupJobsRunning = true + // Stage 1: Expiration Job - Move expired trashed roots to pending_purge const runExpiration = async () => { + if (!this.cleanupJobsRunning) return try { await this.expireTrashedAssets() } catch (e: unknown) { @@ -773,6 +778,7 @@ export class AssetService { // Stage 2: Physical Purge Job - Delete files from S3 and wipe from DB const runPurge = async () => { + if (!this.cleanupJobsRunning) return try { await this.purgePendingAssets() } catch (e: unknown) { @@ -785,6 +791,10 @@ export class AssetService { runPurge() } + stopCleanupJob() { + this.cleanupJobsRunning = false + } + /** * Stage 1: Find root assets that have been in the trash for > 30 days. * Cascade the 'pending_purge' status to all their descendants. @@ -792,13 +802,14 @@ export class AssetService { private async expireTrashedAssets() { const thirtyDaysAgo = new Date(Date.now() - 30 * 24 * 60 * 60 * 1000) - // Find up to 100 expired roots + // Find up to 100 expired roots, ordered by oldest first to avoid starvation const expiredRoots = await this.prismaClient.asset.findMany({ where: { status: 'trashed', deletedAt: { lt: thirtyDaysAgo }, isDeleted: true, }, + orderBy: { deletedAt: 'asc' }, select: { id: true }, take: 100, })