diff --git a/src/api/file.test.ts b/src/api/file.test.ts index 82d73911..bdb3e551 100644 --- a/src/api/file.test.ts +++ b/src/api/file.test.ts @@ -157,10 +157,11 @@ describe('file api', () => { it('POST /files/:fileId/comments', async () => { vi.mocked(assetService.createComment).mockResolvedValue({ id: 'comment-id', - assetId: 'test-id', + assetId: 'file-id', message: 'hello', annotations: null, - creator: { id: 'user1', name: 'user-name' }, + second: null, + creator: { id: 'user-id', name: 'Test User' }, replies: [], attachments: [], mentions: [], @@ -207,10 +208,11 @@ describe('file api', () => { data: [ { id: 'comment-id', - assetId: 'test-id', + assetId: 'file-id', message: 'hello', annotations: null, - creator: { id: 'user1', name: 'user-name' }, + second: null, + creator: { id: 'user-id', name: 'Test User' }, replies: [], attachments: [], mentions: [], diff --git a/src/dtos/asset.ts b/src/dtos/asset.ts index cee55d07..3faa3771 100644 --- a/src/dtos/asset.ts +++ b/src/dtos/asset.ts @@ -189,6 +189,7 @@ export type CommentInfo = { message: string | null // eslint-disable-next-line @typescript-eslint/no-explicit-any annotations: any + second: number | null creator: UserInfo replies: CommentInfo[] attachments: AttachmentInfo[] @@ -204,6 +205,7 @@ export const commentInfoSchema: z.ZodType = z.object({ message: z.string().nullable(), annotations: z.any(), + second: z.number().nullable(), creator: userInfoSchema, replies: z.array(z.lazy(() => commentInfoSchema)), attachments: z.array(attachmentInfoSchema), diff --git a/src/services/asset/asset.test.ts b/src/services/asset/asset.test.ts index 8b9aaa57..b91e0fdb 100644 --- a/src/services/asset/asset.test.ts +++ b/src/services/asset/asset.test.ts @@ -664,6 +664,28 @@ describe('AssetService', () => { expect(list.data[0].replies.length).toBe(1) }) + it('can create and retrieve comments with video timestamp', async () => { + const { user, assets } = await setupBasicAssets() + + const comment = await assetService.createComment({ + assetId: assets.fileA1.id, + userId: user.id, + message: 'Interesting point at 5.5s', + second: 5.5, + attachmentIds: [], + }) + + expect(comment.second).toBe(5.5) + + const retrieved = await assetService.getComment(comment.id) + expect(retrieved.second).toBe(5.5) + + const list = await assetService.listComments(assets.fileA1.id, { + first: 10, + }) + expect(list.data[0].second).toBe(5.5) + }) + it('correctly handles AI comments with agent identity', async () => { const { assets, project } = await setupBasicAssets() diff --git a/src/services/asset/asset.ts b/src/services/asset/asset.ts index fb4e15d9..e1e66396 100644 --- a/src/services/asset/asset.ts +++ b/src/services/asset/asset.ts @@ -1690,6 +1690,7 @@ export class AssetService { assetId: c.assetId, message: c.message, annotations: c.annotation, + second: c.second, creator, replies, attachments, diff --git a/src/ui/components/chat/message-card.tsx b/src/ui/components/chat/message-card.tsx index 8b6b37d5..fbe1b7dc 100644 --- a/src/ui/components/chat/message-card.tsx +++ b/src/ui/components/chat/message-card.tsx @@ -11,12 +11,13 @@ import { } from '@/ui/components/ui/dialog' import { Separator } from '@/ui/components/ui/separator' import { useQuery } from '@tanstack/react-query' -import { Download, File, Terminal } from 'lucide-react' +import { Download, File, Terminal, Clock } from 'lucide-react' import React from 'react' import { formatTimeAgo } from '@/ui/lib/time' import Markdown from 'react-markdown' import { Avatar, AvatarFallback } from '../ui/avatar' import { Skeleton } from '../ui/skeleton' +import { formatTimestamp } from '../viewers/utils' interface MessageCardProps { teamId?: string @@ -27,6 +28,8 @@ interface MessageCardProps { getUser: (id: string) => UserInfo onReply: (message: CommentInfo) => void onViewAttachment: (attachment: AttachmentInfo) => void + onTimestampClick?: (seconds: number) => void + frameRate?: number rootParentId?: string } @@ -48,6 +51,8 @@ export const MessageCard: React.FC = ({ getUser, onReply, onViewAttachment, + onTimestampClick, + frameRate, }) => { const isRunning = !!initialMessage.sessionId && @@ -153,6 +158,18 @@ export const MessageCard: React.FC = ({
{creator?.name || 'Unknown'} + {message.second !== null && message.second !== undefined && frameRate && ( + + )} {new Date(message.createdAt!).toLocaleTimeString([], { hour: '2-digit', diff --git a/src/ui/components/chat/message-input.tsx b/src/ui/components/chat/message-input.tsx index 014b64cc..e71dfda3 100644 --- a/src/ui/components/chat/message-input.tsx +++ b/src/ui/components/chat/message-input.tsx @@ -8,6 +8,7 @@ import { ArrowUp, Brush, ChevronDown, + Clock, FileIcon, Minus, Paperclip, @@ -24,6 +25,7 @@ import { Popover, PopoverContent, PopoverTrigger } from '../ui/popover' import { useAnnotationStore } from '@/ui/stores/annotation-store' import type { Annotation } from '@/ui/types' import { useMutation } from '@tanstack/react-query' +import { formatTimestamp } from '../viewers/utils' type UploadingFile = { id: string // A unique ID for the file, e.g., timestamp + name @@ -40,6 +42,7 @@ interface ChatInputProps { attachmentIds: string[], annotations?: Annotation[], replyToId?: string | null, + second?: number | null, ) => void replyingTo?: CommentInfo | null onCancelReply?: () => void @@ -48,6 +51,8 @@ interface ChatInputProps { initialText?: string hideAnnotationControl?: boolean disableMentions?: boolean + currentTime?: number + frameRate?: number } const PREDEFINED_COLORS = [ @@ -76,11 +81,14 @@ export const ChatInput = React.forwardRef( initialText = '', hideAnnotationControl = false, disableMentions = false, + currentTime, + frameRate, }, ref, ) => { const [uploadingFiles, setUploadingFiles] = useState([]) const [viewingFile, setViewingFile] = useState(null) + const [isTimestampEnabled, setIsTimestampEnabled] = useState(true) // Annotation Store const { @@ -395,7 +403,13 @@ export const ChatInput = React.forwardRef( // Allow sending if annotations exist, even if text is empty if (!processedText && successfulAttachmentIds.length === 0 && annotations.length === 0) return - onSendMessage(processedText, successfulAttachmentIds, annotations, replyingTo?.id) + onSendMessage( + processedText, + successfulAttachmentIds, + annotations, + replyingTo?.id, + isTimestampEnabled ? currentTime : undefined, + ) // Reset editor editorRef.current.innerHTML = '' @@ -566,6 +580,15 @@ export const ChatInput = React.forwardRef(
)} + {isTimestampEnabled && currentTime !== undefined && frameRate !== undefined && ( +
+
+ + {formatTimestamp(currentTime, frameRate)} +
+
+ )} +
( multiple onChange={handleFileSelect} /> +
@@ -375,6 +387,8 @@ export function FileViewerRightSidebar({ bots={enabledBots} hideAnnotationControl={hideAnnotationControl} disableMentions={isPublic} + currentTime={currentTime} + frameRate={file?.media?.metadata?.frameRate || 30} />
diff --git a/src/ui/components/file-viewer.tsx b/src/ui/components/file-viewer.tsx index bea8cc0a..9d70bbc0 100644 --- a/src/ui/components/file-viewer.tsx +++ b/src/ui/components/file-viewer.tsx @@ -16,10 +16,18 @@ type FileViewerProps = { videoRef?: RefObject onPlay?: () => void onPause?: () => void + onTimeUpdate?: (time: number) => void annotations?: Annotation[] } -export function FileViewer({ file, videoRef, onPlay, onPause, annotations }: FileViewerProps) { +export function FileViewer({ + file, + videoRef, + onPlay, + onPause, + onTimeUpdate, + annotations, +}: FileViewerProps) { const { width: screenWidth } = useScreenSize() const isImage = file.mediaType?.startsWith('image/') const isVideo = file.mediaType?.startsWith('video/') @@ -186,6 +194,7 @@ export function FileViewer({ file, videoRef, onPlay, onPause, annotations }: Fil playerRef={videoRef} onPlay={onPlay} onPause={onPause} + onTimeUpdate={onTimeUpdate} annotations={displayAnnotations} /> )} diff --git a/src/ui/components/public-share-manager.tsx b/src/ui/components/public-share-manager.tsx index e3f9f4ad..f8438a74 100644 --- a/src/ui/components/public-share-manager.tsx +++ b/src/ui/components/public-share-manager.tsx @@ -89,6 +89,7 @@ export function PublicShareManager({ const [isRightSidebarCollapsed] = useState(false) const videoRef = useRef(null) const [annotations, setAnnotations] = useState([]) + const [currentTime, setCurrentTime] = useState(0) const { data: foldersData, @@ -257,11 +258,19 @@ export function PublicShareManager({ const newAnnotations = comment.annotations as Annotation[] if (newAnnotations && newAnnotations.length > 0) { setAnnotations(newAnnotations) + } else { + setAnnotations([]) + } + + if (comment.second !== null && comment.second !== undefined) { + if (videoRef.current) { + videoRef.current.currentTime(comment.second) + videoRef.current.pause() + } + } else if (newAnnotations && newAnnotations.length > 0) { if (videoRef.current) { videoRef.current.pause() } - } else { - setAnnotations([]) } } @@ -373,6 +382,7 @@ export function PublicShareManager({ file={viewingFileData} videoRef={videoRef} onPlay={handlePlay} + onTimeUpdate={setCurrentTime} annotations={annotations} /> )} @@ -430,6 +440,7 @@ export function PublicShareManager({ onCommentSelect={handleCommentSelect} isPublic={true} shareId={shareInfo.id} + currentTime={currentTime} />
diff --git a/src/ui/components/viewers/utils.ts b/src/ui/components/viewers/utils.ts index 0c5a4593..b20f9dd4 100644 --- a/src/ui/components/viewers/utils.ts +++ b/src/ui/components/viewers/utils.ts @@ -10,6 +10,16 @@ export const formatTime = (seconds: number): string => { return `${mm}:${ss}` } +export const formatTimestamp = (seconds: number, fps: number): string => { + if (isNaN(seconds)) return '00:00:00:00' + const hh = Math.floor(seconds / 3600) + const mm = Math.floor((seconds % 3600) / 60) + const ss = Math.floor(seconds % 60) + const ff = Math.floor((seconds % 1) * fps) + + return `${hh.toString().padStart(2, '0')}:${mm.toString().padStart(2, '0')}:${ss.toString().padStart(2, '0')}:${ff.toString().padStart(2, '0')}` +} + export const formatFrame = (seconds: number, fps: number): number => { if (isNaN(seconds) || !fps) return 0 return Math.floor(seconds * fps) diff --git a/src/ui/components/viewers/video-player.tsx b/src/ui/components/viewers/video-player.tsx index aae83806..9e8c4aa7 100644 --- a/src/ui/components/viewers/video-player.tsx +++ b/src/ui/components/viewers/video-player.tsx @@ -51,6 +51,7 @@ interface VideoPlayerProps { playerRef?: React.RefObject onPlay?: () => void onPause?: () => void + onTimeUpdate?: (time: number) => void annotations?: Annotation[] } @@ -299,6 +300,7 @@ const VideoPlayer: React.FC = ({ playerRef: passedPlayerRef, onPlay, onPause, + onTimeUpdate, annotations, }) => { const localPlayerRef = useRef(null) @@ -494,6 +496,10 @@ const VideoPlayer: React.FC = ({ duration: duration || prev.duration, progress: duration > 0 ? (current / duration) * 100 : 0, })) + + if (onTimeUpdate) { + onTimeUpdate(current) + } }) player.on('volumechange', () => { diff --git a/src/ui/routes/projects/$projectId/files/$fileId.tsx b/src/ui/routes/projects/$projectId/files/$fileId.tsx index 2f928103..15eb70a6 100644 --- a/src/ui/routes/projects/$projectId/files/$fileId.tsx +++ b/src/ui/routes/projects/$projectId/files/$fileId.tsx @@ -34,6 +34,7 @@ function FileViewPage() { const [leftSidebarWidth, setLeftSidebarWidth] = useState(280) const [rightSidebarWidth, setRightSidebarWidth] = useState(360) const [annotations, setAnnotations] = useState([]) + const [currentTime, setCurrentTime] = useState(0) const $patchMetadata = client.api.files[':fileId'].metadata.$patch const { mutate: patchMetadata } = useMutation< InferResponseType, @@ -197,11 +198,19 @@ function FileViewPage() { const newAnnotations = comment.annotations as Annotation[] if (newAnnotations && newAnnotations.length > 0) { setAnnotations(newAnnotations) + } else { + setAnnotations([]) + } + + if (comment.second !== null && comment.second !== undefined) { + if (videoRef.current) { + videoRef.current.currentTime(comment.second) + videoRef.current.pause() + } + } else if (newAnnotations && newAnnotations.length > 0) { if (videoRef.current) { videoRef.current.pause() } - } else { - setAnnotations([]) } } @@ -244,29 +253,32 @@ function FileViewPage() { file={fileData as unknown as AssetInfo} videoRef={videoRef} onPlay={handlePlay} + onTimeUpdate={setCurrentTime} annotations={annotations} /> - - {!isRightSidebarCollapsed && ( + + {!isRightSidebarCollapsed && ( <> { - setRightSidebarWidth((prev) => Math.max(240, Math.min(600, prev - delta))) + setRightSidebarWidth((prev) => Math.max(300, Math.min(600, prev - delta))) }} className="hidden md:block" />
- )} + )} + )