From ccfcdce23cd8cd3350e9892ed94e02e34a89a849 Mon Sep 17 00:00:00 2001 From: yiling Date: Sun, 5 Jul 2026 15:57:29 +0800 Subject: [PATCH] fix(upload): correct .wma MIME type to audio prefix on upload and add tests --- packages/core/src/upload/upload.test.ts | 33 +++++++++++++++++++ packages/core/src/upload/upload.ts | 7 +++- .../components/file-browser/file-browser.tsx | 11 +++++-- packages/webui/e2e/harness/fixture.ts | 4 ++- 4 files changed, 51 insertions(+), 4 deletions(-) diff --git a/packages/core/src/upload/upload.test.ts b/packages/core/src/upload/upload.test.ts index 4fbece50..f3c0b6e1 100644 --- a/packages/core/src/upload/upload.test.ts +++ b/packages/core/src/upload/upload.test.ts @@ -388,4 +388,37 @@ describe('UploadService', () => { expect(result.data[0].id).toBe(task.id) expect(result.data[0].name).toBe('test-upload-task') }) + + it('should correct the mediaType for .wma files that browser incorrectly reports as video', async () => { + const req = { + parentId: parentId, + files: [ + { + name: 'song.wma', + id: '1', + size: 100, + type: 'file' as const, + mediaType: 'video/x-ms-wma', + children: [], + }, + { + name: 'other_song.WMA', + id: '2', + size: 200, + type: 'file' as const, + mediaType: 'video/x-ms-asf', + children: [], + }, + ], + } + + const resp = await uploadService.createUploadTask(userId, req) + expect(resp.taskId).toBeDefined() + + const song1 = await prisma.asset.findFirst({ where: { name: 'song.wma' } }) + expect(song1?.mediaType).toBe('audio/x-ms-wma') + + const song2 = await prisma.asset.findFirst({ where: { name: 'other_song.WMA' } }) + expect(song2?.mediaType).toBe('audio/x-ms-asf') + }) }) diff --git a/packages/core/src/upload/upload.ts b/packages/core/src/upload/upload.ts index 25b448bd..016c1405 100644 --- a/packages/core/src/upload/upload.ts +++ b/packages/core/src/upload/upload.ts @@ -134,13 +134,18 @@ export class UploadService { key = `files/${ulid()}/${sanitizeFilename(file.name)}` } + let mediaType = file.mediaType + if (mediaType && file.name.toLowerCase().endsWith('.wma') && mediaType.startsWith('video/')) { + mediaType = mediaType.replace(/^video\//, 'audio/') + } + const newAsset = await tx.asset.create({ data: { name: file.name, type: assetType, storageKey: key ? { create: { key } } : undefined, sortIndex: newSortIndex, - mediaType: file.mediaType, + mediaType: mediaType, status: assetType === AssetType.folder ? AssetStatus.uploaded : AssetStatus.uploading, sizeByte: file.size, creator: userId ? { connect: { id: userId } } : undefined, diff --git a/packages/webui/components/file-browser/file-browser.tsx b/packages/webui/components/file-browser/file-browser.tsx index aa1857f4..2bfb9d62 100644 --- a/packages/webui/components/file-browser/file-browser.tsx +++ b/packages/webui/components/file-browser/file-browser.tsx @@ -513,7 +513,10 @@ export function FileBrowser({ fileCount: 0, type: 'file', status: hasUrl ? 'uploading' : 'error', - mediaType: f.file.type || null, + mediaType: + f.file.name.toLowerCase().endsWith('.wma') && f.file.type?.startsWith('video/') + ? f.file.type.replace(/^video\//, 'audio/') + : f.file.type || null, createdAt: new Date().toISOString(), updatedAt: new Date().toISOString(), } @@ -846,13 +849,17 @@ export function FileBrowser({ } const fileWithId = { file, id: ulid() } fileWithIds.push(fileWithId) + let mediaType = file.type + if (fileName.toLowerCase().endsWith('.wma') && mediaType?.startsWith('video/')) { + mediaType = mediaType.replace(/^video\//, 'audio/') + } currentLevel.push({ name: fileName, size: file.size, type: 'file', id: fileWithId.id, children: [], - mediaType: file.type, + mediaType, }) } filesToUpload = fileWithIds diff --git a/packages/webui/e2e/harness/fixture.ts b/packages/webui/e2e/harness/fixture.ts index 234254e9..18017bc9 100644 --- a/packages/webui/e2e/harness/fixture.ts +++ b/packages/webui/e2e/harness/fixture.ts @@ -139,7 +139,9 @@ export const longAudioVideoAsset: AssetInfo = { export const SAMPLE_AUDIO_URL = '/sample-audio.mp4' export const SAMPLE_AUDIO_DURATION = 3.0 -export const SAMPLE_AUDIO_COMPUTED_TOTAL_FRAMES = Math.round(SAMPLE_AUDIO_DURATION * SAMPLE_FRAME_RATE) +export const SAMPLE_AUDIO_COMPUTED_TOTAL_FRAMES = Math.round( + SAMPLE_AUDIO_DURATION * SAMPLE_FRAME_RATE, +) export const sampleAudioAsset: AssetInfo = { ...sampleVideoAsset,