mirror of
https://github.com/shumaiOne/shumai.git
synced 2026-11-22 18:08:24 +00:00
* feat(mcp): support tool-level directTools array and 3-state UI configuration * refactor(mcp): refine tool hint explanation and separate server instructions block * style(mcp): display tool count in header title and split option hints into 3 lines * style(mcp): update tools description paragraph and place bulk buttons on a separate row * fix(mcp): enforce excludeTools in proxy path and align direct-tool counts - Filter the per-agent tool registry by excludeTools at build time (DB cache and lazy-connect paths), so excluded tools are unreachable through the mcp proxy (call, search, list, describe) — matching pi-mcp-adapter where isToolAllowed gates both direct and gateway exposure. - Add shared isDirectTool predicate (matches original or prefixed name) used by both buildDirectTools and the proxy description counts, so the advertised direct/proxy counts can no longer drift from actual registration; toolCount now reflects allowed tools only. - Remove the legacy boolean directTools branch (no legacy data exists). - Drop the now-unused mcp_excluded_tools_hint i18n key and regenerate Paraglide messages. - Extend unit tests: excluded tools are not counted, listed, searched, or callable via the proxy; prefixed-name directTools configs count correctly.
477 lines
18 KiB
TypeScript
477 lines
18 KiB
TypeScript
import React, { useState } from 'react'
|
|
import { client } from '@/ui/api/client'
|
|
import { useMutation, useQuery, useQueryClient } from '@tanstack/react-query'
|
|
import {
|
|
Server,
|
|
Loader2,
|
|
MoreVertical,
|
|
Plus,
|
|
Trash2,
|
|
ShieldCheck,
|
|
CheckCircle2,
|
|
AlertCircle,
|
|
Clock,
|
|
Key,
|
|
Wrench,
|
|
} from 'lucide-react'
|
|
import { Card, CardContent, CardDescription, CardHeader, CardTitle } from '@/ui/components/ui/card'
|
|
import { Button } from '@/ui/components/ui/button'
|
|
import { Badge } from '@/ui/components/ui/badge'
|
|
import {
|
|
DropdownMenu,
|
|
DropdownMenuContent,
|
|
DropdownMenuItem,
|
|
DropdownMenuSeparator,
|
|
DropdownMenuTrigger,
|
|
} from '@/ui/components/ui/dropdown-menu'
|
|
import {
|
|
AlertDialog,
|
|
AlertDialogAction,
|
|
AlertDialogCancel,
|
|
AlertDialogContent,
|
|
AlertDialogDescription,
|
|
AlertDialogFooter,
|
|
AlertDialogHeader,
|
|
AlertDialogTitle,
|
|
} from '@/ui/components/ui/alert-dialog'
|
|
import {
|
|
Select,
|
|
SelectContent,
|
|
SelectItem,
|
|
SelectTrigger,
|
|
SelectValue,
|
|
} from '@/ui/components/ui/select'
|
|
import { McpServerInfo, McpServerPermission } from '@shumai/dtos'
|
|
import { m } from '@/ui/paraglide/messages.js'
|
|
import { usePermissions } from '@/ui/hooks/use-permissions'
|
|
import { toast } from 'sonner'
|
|
import { McpServerFormDialog } from './McpServerFormDialog'
|
|
|
|
interface McpConfigCardProps {
|
|
teamId: string
|
|
}
|
|
|
|
export const McpConfigCard: React.FC<McpConfigCardProps> = ({ teamId }) => {
|
|
const queryClient = useQueryClient()
|
|
const { canAdmin } = usePermissions()
|
|
|
|
const [isAddFormOpen, setIsAddFormOpen] = useState(false)
|
|
const [editingServer, setEditingServer] = useState<McpServerInfo | null>(null)
|
|
const [deletingServer, setDeletingServer] = useState<McpServerInfo | null>(null)
|
|
const [authenticatingServerId, setAuthenticatingServerId] = useState<string | null>(null)
|
|
|
|
// Fetch MCP Servers
|
|
const { data, isLoading } = useQuery({
|
|
queryKey: ['teams', teamId, 'mcp', 'servers'],
|
|
queryFn: async () => {
|
|
const res = await client.api.teams[':teamId'].mcp.servers.$get({ param: { teamId } })
|
|
if (!res.ok) throw new Error(m.failed_load_settings())
|
|
return await res.json()
|
|
},
|
|
})
|
|
|
|
// Delete Server Mutation
|
|
const deleteMutation = useMutation({
|
|
mutationFn: async (id: string) => {
|
|
const res = await client.api.mcp.servers[':id'].$delete({ param: { id } })
|
|
if (!res.ok) throw new Error(m.failed_to_delete())
|
|
},
|
|
onSuccess: () => {
|
|
toast.success(m.delete())
|
|
queryClient.invalidateQueries({ queryKey: ['teams', teamId, 'mcp', 'servers'] })
|
|
setDeletingServer(null)
|
|
},
|
|
onError: (err: Error) => {
|
|
toast.error(err.message)
|
|
},
|
|
})
|
|
|
|
// Update Permission Mutation
|
|
const updatePermissionMutation = useMutation({
|
|
mutationFn: async ({ id, permission }: { id: string; permission: McpServerPermission }) => {
|
|
const res = await client.api.mcp.servers[':id'].permission.$patch({
|
|
param: { id },
|
|
json: { permission },
|
|
})
|
|
if (!res.ok) throw new Error(m.failed_to_update_permission())
|
|
},
|
|
onSuccess: () => {
|
|
queryClient.invalidateQueries({ queryKey: ['teams', teamId, 'mcp', 'servers'] })
|
|
},
|
|
onError: (err: Error) => {
|
|
toast.error(err.message)
|
|
},
|
|
})
|
|
|
|
// Enable/Disable Mutation
|
|
// (Removed: enable/disable now happens per-agent via AgentMcpServer assignment.)
|
|
|
|
// Disconnect Auth Mutation
|
|
const disconnectAuthMutation = useMutation({
|
|
mutationFn: async (id: string) => {
|
|
const res = await client.api.mcp.servers[':id'].auth.$delete({ param: { id } })
|
|
if (!res.ok) throw new Error('Failed to disconnect auth')
|
|
},
|
|
onSuccess: () => {
|
|
toast.success(m.mcp_disconnect_auth())
|
|
queryClient.invalidateQueries({ queryKey: ['teams', teamId, 'mcp', 'servers'] })
|
|
},
|
|
onError: (err: Error) => {
|
|
toast.error(err.message)
|
|
},
|
|
})
|
|
|
|
// Start Auth Flow (OAuth Popup / Bearer)
|
|
const handleStartAuth = async (serverId: string) => {
|
|
setAuthenticatingServerId(serverId)
|
|
try {
|
|
const res = await client.api.mcp.servers[':id'].auth.start.$post({
|
|
param: { id: serverId },
|
|
})
|
|
if (!res.ok) {
|
|
const err = (await res.json().catch(() => ({}))) as { error?: string }
|
|
throw new Error(err.error || m.mcp_auth_failed())
|
|
}
|
|
const data = (await res.json()) as { authorizationUrl?: string; status?: string }
|
|
if (data.status === 'authenticated') {
|
|
toast.success(m.mcp_auth_success())
|
|
queryClient.invalidateQueries({ queryKey: ['teams', teamId, 'mcp', 'servers'] })
|
|
setAuthenticatingServerId(null)
|
|
return
|
|
}
|
|
|
|
if (data.authorizationUrl) {
|
|
// Open OAuth popup window
|
|
const width = 600
|
|
const height = 700
|
|
const left = window.screenX + (window.outerWidth - width) / 2
|
|
const top = window.screenY + (window.outerHeight - height) / 2
|
|
const popup = window.open(
|
|
data.authorizationUrl,
|
|
'mcp_oauth_popup',
|
|
`width=${width},height=${height},left=${left},top=${top},scrollbars=yes`,
|
|
)
|
|
|
|
const handleMessage = (event: MessageEvent) => {
|
|
if (event.data?.type === 'mcp-oauth-callback') {
|
|
window.removeEventListener('message', handleMessage)
|
|
setAuthenticatingServerId(null)
|
|
if (event.data.ok) {
|
|
toast.success(m.mcp_auth_success())
|
|
queryClient.invalidateQueries({ queryKey: ['teams', teamId, 'mcp', 'servers'] })
|
|
} else {
|
|
toast.error(event.data.message || m.mcp_auth_failed())
|
|
}
|
|
}
|
|
}
|
|
|
|
window.addEventListener('message', handleMessage)
|
|
|
|
// Monitor popup closure
|
|
const checkClosed = setInterval(() => {
|
|
if (!popup || popup.closed) {
|
|
clearInterval(checkClosed)
|
|
window.removeEventListener('message', handleMessage)
|
|
setAuthenticatingServerId(null)
|
|
queryClient.invalidateQueries({ queryKey: ['teams', teamId, 'mcp', 'servers'] })
|
|
}
|
|
}, 1000)
|
|
}
|
|
} catch (err) {
|
|
toast.error(err instanceof Error ? err.message : m.mcp_auth_failed())
|
|
setAuthenticatingServerId(null)
|
|
}
|
|
}
|
|
|
|
const servers = data?.servers || []
|
|
|
|
const renderStatusBadge = (server: McpServerInfo) => {
|
|
switch (server.status) {
|
|
case 'connected':
|
|
return (
|
|
<Badge
|
|
variant="secondary"
|
|
className="gap-1 bg-emerald-500/10 text-emerald-600 border-emerald-500/20 text-[10px]"
|
|
>
|
|
<CheckCircle2 className="w-3 h-3" />
|
|
{m.mcp_status_connected()}
|
|
</Badge>
|
|
)
|
|
case 'needs_auth':
|
|
return (
|
|
<Badge
|
|
variant="secondary"
|
|
className="gap-1 bg-amber-500/10 text-amber-600 border-amber-500/20 text-[10px]"
|
|
>
|
|
<Key className="w-3 h-3" />
|
|
{m.mcp_status_needs_auth()}
|
|
</Badge>
|
|
)
|
|
case 'failed':
|
|
return (
|
|
<Badge
|
|
variant="secondary"
|
|
className="gap-1 bg-red-500/10 text-red-600 border-red-500/20 text-[10px]"
|
|
>
|
|
<AlertCircle className="w-3 h-3" />
|
|
{m.mcp_status_failed()}
|
|
</Badge>
|
|
)
|
|
default:
|
|
return (
|
|
<Badge variant="outline" className="gap-1 text-[10px]">
|
|
<Clock className="w-3 h-3 text-muted-foreground" />
|
|
{m.mcp_status_not_connected()}
|
|
</Badge>
|
|
)
|
|
}
|
|
}
|
|
|
|
return (
|
|
<Card>
|
|
<CardHeader className="flex flex-row items-center justify-between space-y-0 pb-7">
|
|
<div className="flex items-center gap-3">
|
|
<div className="p-2 bg-primary/10 text-primary rounded-lg">
|
|
<Server className="w-6 h-6" />
|
|
</div>
|
|
<div>
|
|
<CardTitle className="text-xl font-bold">{m.mcp_servers()}</CardTitle>
|
|
<CardDescription>{m.mcp_servers_description()}</CardDescription>
|
|
</div>
|
|
</div>
|
|
{canAdmin && (
|
|
<Button onClick={() => setIsAddFormOpen(true)} className="gap-2">
|
|
<Plus className="w-4 h-4" /> {m.add_mcp_server()}
|
|
</Button>
|
|
)}
|
|
</CardHeader>
|
|
<CardContent>
|
|
{isLoading ? (
|
|
<div className="flex justify-center py-10">
|
|
<Loader2 className="w-8 h-8 animate-spin text-primary" />
|
|
</div>
|
|
) : servers.length === 0 ? (
|
|
<div className="text-center py-12 border-2 border-dashed border-border rounded-xl">
|
|
<div className="mx-auto w-12 h-12 bg-muted rounded-full flex items-center justify-center mb-4 text-muted-foreground">
|
|
<Server className="w-6 h-6" />
|
|
</div>
|
|
<h3 className="text-base font-semibold">{m.no_mcp_servers_installed()}</h3>
|
|
<p className="text-xs text-muted-foreground mt-1 max-w-sm mx-auto">
|
|
{m.add_mcp_server_to_get_started()}
|
|
</p>
|
|
{canAdmin && (
|
|
<Button
|
|
onClick={() => setIsAddFormOpen(true)}
|
|
className="mt-4 gap-2"
|
|
variant="outline"
|
|
>
|
|
<Plus className="w-4 h-4" /> {m.add_mcp_server()}
|
|
</Button>
|
|
)}
|
|
</div>
|
|
) : (
|
|
<div className="space-y-4">
|
|
{servers.map((server) => {
|
|
const isAuthenticating = authenticatingServerId === server.id
|
|
const needsAuth =
|
|
server.status === 'needs_auth' ||
|
|
(!server.hasCredential && server.authType !== 'none')
|
|
|
|
return (
|
|
<div
|
|
key={server.id}
|
|
onClick={() => canAdmin && setEditingServer(server)}
|
|
className={`p-4 bg-card rounded-xl border border-border flex flex-col justify-between hover:shadow-md transition-all group ${
|
|
canAdmin ? 'cursor-pointer' : ''
|
|
}`}
|
|
>
|
|
{/* Row 1: name + three-dot */}
|
|
<div className="flex items-start justify-between gap-2 mb-2">
|
|
<h4 className="font-bold text-foreground flex items-center gap-2 min-w-0">
|
|
<Server className="w-4 h-4 text-muted-foreground shrink-0" />
|
|
<span className="truncate">{server.name}</span>
|
|
<Badge variant="outline" className="text-[10px] uppercase shrink-0">
|
|
{server.transport}
|
|
</Badge>
|
|
</h4>
|
|
{canAdmin && (
|
|
<DropdownMenu modal={false}>
|
|
<DropdownMenuTrigger asChild onClick={(e) => e.stopPropagation()}>
|
|
<Button variant="ghost" size="icon" className="h-8 w-8 shrink-0">
|
|
<MoreVertical className="w-4 h-4" />
|
|
</Button>
|
|
</DropdownMenuTrigger>
|
|
<DropdownMenuContent align="end">
|
|
{server.status !== 'connected' &&
|
|
(server.authType !== 'none' || server.hasCredential) ? (
|
|
<DropdownMenuItem
|
|
onClick={(e) => {
|
|
e.stopPropagation()
|
|
handleStartAuth(server.id)
|
|
}}
|
|
>
|
|
<Key className="w-4 h-4 mr-2" />
|
|
{m.mcp_connect_auth()}
|
|
</DropdownMenuItem>
|
|
) : null}
|
|
|
|
{server.hasCredential && (
|
|
<DropdownMenuItem
|
|
onClick={(e) => {
|
|
e.stopPropagation()
|
|
disconnectAuthMutation.mutate(server.id)
|
|
}}
|
|
className="text-amber-600"
|
|
>
|
|
<ShieldCheck className="w-4 h-4 mr-2" />
|
|
{m.mcp_disconnect_auth()}
|
|
</DropdownMenuItem>
|
|
)}
|
|
|
|
{((server.status !== 'connected' &&
|
|
(server.authType !== 'none' || server.hasCredential)) ||
|
|
server.hasCredential) && <DropdownMenuSeparator />}
|
|
<DropdownMenuItem
|
|
onClick={(e) => {
|
|
e.stopPropagation()
|
|
setDeletingServer(server)
|
|
}}
|
|
className="text-red-600"
|
|
>
|
|
<Trash2 className="w-4 h-4 mr-2" />
|
|
{m.delete()}
|
|
</DropdownMenuItem>
|
|
</DropdownMenuContent>
|
|
</DropdownMenu>
|
|
)}
|
|
</div>
|
|
|
|
{/* Row 2: description + url + lastError */}
|
|
<div className="space-y-1">
|
|
<p className="text-sm text-muted-foreground line-clamp-2">
|
|
{server.description || m.no_description_provided()}
|
|
</p>
|
|
<p className="font-mono text-[10px] text-muted-foreground/70 truncate">
|
|
{server.url}
|
|
</p>
|
|
{server.lastError && (
|
|
<p className="text-[10px] text-red-500/90 truncate font-mono">
|
|
{server.lastError}
|
|
</p>
|
|
)}
|
|
</div>
|
|
|
|
{/* Row 3: status + updated (left), permission + connect (right) */}
|
|
<div className="mt-4 flex items-center justify-between gap-2 pt-2 border-t border-border/50 text-xs">
|
|
<div className="flex items-center gap-2 min-w-0">
|
|
{renderStatusBadge(server)}
|
|
<Badge variant="outline" className="text-[10px] gap-1 shrink-0">
|
|
<Wrench className="w-3 h-3 text-muted-foreground" />
|
|
{m.mcp_tools_count({ count: server.toolCount })}
|
|
</Badge>
|
|
<span className="text-[10px] text-muted-foreground uppercase tracking-wider font-semibold whitespace-nowrap">
|
|
{m.updated_date()} {new Date(server.updatedAt).toLocaleDateString()}
|
|
</span>
|
|
</div>
|
|
<div
|
|
className="flex items-center gap-2 shrink-0"
|
|
onClick={(e) => e.stopPropagation()}
|
|
>
|
|
{canAdmin ? (
|
|
<Select
|
|
value={server.permission}
|
|
onValueChange={(permission) =>
|
|
updatePermissionMutation.mutate({
|
|
id: server.id,
|
|
permission: permission as McpServerPermission,
|
|
})
|
|
}
|
|
>
|
|
<SelectTrigger className="h-7 text-xs px-2 bg-background border-border w-[130px]">
|
|
<SelectValue />
|
|
</SelectTrigger>
|
|
<SelectContent align="end">
|
|
<SelectItem value="reviewer">{m.permission_all_users()}</SelectItem>
|
|
<SelectItem value="editor">
|
|
{m.permission_owner_and_editor()}
|
|
</SelectItem>
|
|
<SelectItem value="owner">{m.permission_owner_only()}</SelectItem>
|
|
</SelectContent>
|
|
</Select>
|
|
) : (
|
|
<Badge variant="outline" className="text-[10px]">
|
|
{server.permission === 'reviewer'
|
|
? m.permission_all_users()
|
|
: server.permission === 'editor'
|
|
? m.permission_owner_and_editor()
|
|
: m.permission_owner_only()}
|
|
</Badge>
|
|
)}
|
|
{/* Connect button — right end of the row */}
|
|
{needsAuth && canAdmin && (
|
|
<Button
|
|
size="sm"
|
|
variant="default"
|
|
onClick={(e) => {
|
|
e.stopPropagation()
|
|
handleStartAuth(server.id)
|
|
}}
|
|
disabled={isAuthenticating}
|
|
className="gap-1.5 bg-amber-600 hover:bg-amber-700 text-white text-xs"
|
|
>
|
|
{isAuthenticating ? (
|
|
<Loader2 className="w-3.5 h-3.5 animate-spin" />
|
|
) : (
|
|
<Key className="w-3.5 h-3.5" />
|
|
)}
|
|
{m.mcp_connect_auth()}
|
|
</Button>
|
|
)}
|
|
</div>
|
|
</div>
|
|
</div>
|
|
)
|
|
})}
|
|
</div>
|
|
)}
|
|
</CardContent>
|
|
|
|
{/* Form Dialog for Add / Edit */}
|
|
<McpServerFormDialog
|
|
isOpen={isAddFormOpen || !!editingServer}
|
|
onClose={() => {
|
|
setIsAddFormOpen(false)
|
|
setEditingServer(null)
|
|
}}
|
|
teamId={teamId}
|
|
server={editingServer}
|
|
/>
|
|
|
|
{/* Delete Confirmation Alert */}
|
|
<AlertDialog
|
|
open={!!deletingServer}
|
|
onOpenChange={(open) => !open && setDeletingServer(null)}
|
|
>
|
|
<AlertDialogContent>
|
|
<AlertDialogHeader>
|
|
<AlertDialogTitle>{m.delete_mcp_server()}</AlertDialogTitle>
|
|
<AlertDialogDescription>
|
|
{m.delete_mcp_server_confirmation({ name: deletingServer?.name || '' })}
|
|
</AlertDialogDescription>
|
|
</AlertDialogHeader>
|
|
<AlertDialogFooter>
|
|
<AlertDialogCancel>{m.cancel()}</AlertDialogCancel>
|
|
<AlertDialogAction
|
|
onClick={() => deletingServer && deleteMutation.mutate(deletingServer.id)}
|
|
className="bg-red-600 hover:bg-red-700 text-white"
|
|
>
|
|
{deleteMutation.isPending && <Loader2 className="w-4 h-4 mr-2 animate-spin" />}
|
|
{m.delete()}
|
|
</AlertDialogAction>
|
|
</AlertDialogFooter>
|
|
</AlertDialogContent>
|
|
</AlertDialog>
|
|
</Card>
|
|
)
|
|
}
|