feat(webui): support custom timestamp formatting for PDF viewer comments (P9)

This commit is contained in:
yiling
2026-07-18 11:20:13 +08:00
parent 2b72f3038a
commit ea201ad19f
5 changed files with 27 additions and 5 deletions
@@ -51,6 +51,7 @@ interface MessageCardProps {
onSelect?: () => void
frameRate?: number
startTimecode?: string
formatTimestamp?: (second: number) => string
rootParentId?: string
}
@@ -111,6 +112,7 @@ export const MessageCard: React.FC<MessageCardProps> = ({
onSelect,
frameRate,
startTimecode,
formatTimestamp,
}) => {
const message = initialMessage
const hasDrawInfo =
@@ -124,10 +126,14 @@ export const MessageCard: React.FC<MessageCardProps> = ({
const { videoTimeDisplayMode } = useUiStore()
const displayTime = React.useMemo(() => {
if (message.second === null || message.second === undefined || !frameRate) return ''
if (message.second === null || message.second === undefined) return ''
if (formatTimestamp) {
return formatTimestamp(message.second)
}
if (!frameRate) return ''
const frameIndex = Math.round(message.second * frameRate)
return formatTimecode(frameIndex, frameRate, videoTimeDisplayMode, startTimecode)
}, [message.second, frameRate, videoTimeDisplayMode, startTimecode])
}, [message.second, frameRate, videoTimeDisplayMode, startTimecode, formatTimestamp])
const { data: me } = useQuery({
queryKey: ['teams', teamId, 'me'],
@@ -57,6 +57,7 @@ interface ChatInputProps {
currentTime?: number
frameRate?: number
startTimecode?: string
formatTimestamp?: (second: number) => string
onTyping?: () => void
}
@@ -88,6 +89,7 @@ export const ChatInput = React.forwardRef<HTMLDivElement, ChatInputProps>(
currentTime,
frameRate,
startTimecode,
formatTimestamp,
onTyping,
},
ref,
@@ -98,10 +100,14 @@ export const ChatInput = React.forwardRef<HTMLDivElement, ChatInputProps>(
const { videoTimeDisplayMode } = useUiStore()
const displayTime = React.useMemo(() => {
if (currentTime === undefined || !frameRate) return ''
if (currentTime === undefined) return ''
if (formatTimestamp) {
return formatTimestamp(currentTime)
}
if (!frameRate) return ''
const frameIndex = Math.round(currentTime * frameRate)
return formatTimecode(frameIndex, frameRate, videoTimeDisplayMode, startTimecode)
}, [currentTime, frameRate, videoTimeDisplayMode, startTimecode])
}, [currentTime, frameRate, videoTimeDisplayMode, startTimecode, formatTimestamp])
const { teamId, ensureTeamIdForProject } = useTeamContextStore()
const { members: storeMembers, loading: membersLoading, fetchMembers } = useMemberStore()
@@ -135,7 +141,12 @@ export const ChatInput = React.forwardRef<HTMLDivElement, ChatInputProps>(
const [hasContent, setHasContent] = useState(false)
const paddingLeftClass = React.useMemo(() => {
if (!isTimestampEnabled || currentTime === undefined || !frameRate || hasContent) {
if (
!isTimestampEnabled ||
currentTime === undefined ||
(!formatTimestamp && !frameRate) ||
hasContent
) {
return ''
}
if (videoTimeDisplayMode === 'timecode') {
@@ -355,6 +355,7 @@ export function FileViewerRightSidebar({
onReply={setReplyingTo}
onViewAttachment={setViewingAttachment}
hasReplies={!!comment.replies?.length}
formatTimestamp={viewerDef?.commentsConfig?.formatTimestamp}
frameRate={
viewerDef?.commentsConfig?.hasTimestamp
? file?.media?.metadata?.frameRate || 30
@@ -381,6 +382,7 @@ export function FileViewerRightSidebar({
onViewAttachment={setViewingAttachment}
hasReplies={false}
isLastReply={index === (comment.replies?.length ?? 0) - 1}
formatTimestamp={viewerDef?.commentsConfig?.formatTimestamp}
frameRate={
viewerDef?.commentsConfig?.hasTimestamp
? file?.media?.metadata?.frameRate || 30
@@ -419,6 +421,7 @@ export function FileViewerRightSidebar({
hideAnnotationControl={hideAnnotationControl}
disableMentions={isPublic}
currentTime={viewerDef?.commentsConfig?.hasTimestamp ? currentTime : undefined}
formatTimestamp={viewerDef?.commentsConfig?.formatTimestamp}
frameRate={
viewerDef?.commentsConfig?.hasTimestamp
? file?.media?.metadata?.frameRate || 30
@@ -10,5 +10,6 @@ export const pdfTypeDefinition: FileTypeDefinition = {
hasTimestamp: true,
hasAnnotations: true,
hasAiBots: true,
formatTimestamp: (second: number) => `P${Math.round(second)}`,
},
}
@@ -49,5 +49,6 @@ export interface FileTypeDefinition {
hasTimestamp?: boolean
hasAnnotations?: boolean
hasAiBots?: boolean
formatTimestamp?: (second: number) => string
}
}