mirror of
https://github.com/shumaiOne/shumai.git
synced 2026-11-22 15:18:24 +00:00
fix(shortcuts): resolve keyboard accessibility and contenteditable issues
This commit is contained in:
@@ -871,7 +871,10 @@ describe('AssetService', () => {
|
||||
|
||||
// 7. Verify S3 deletion was called
|
||||
const { s3Service } = await import('@shumai/core/src/s3/s3')
|
||||
expect(s3Service.deleteObject).toHaveBeenCalledWith('shumai', 'attachments/test-attachment-file.png')
|
||||
expect(s3Service.deleteObject).toHaveBeenCalledWith(
|
||||
'shumai',
|
||||
'attachments/test-attachment-file.png',
|
||||
)
|
||||
})
|
||||
|
||||
it('can create and retrieve comments with video timestamp', async () => {
|
||||
|
||||
@@ -1442,7 +1442,9 @@ export class AssetService {
|
||||
const teamId = comment.asset.project?.teamId
|
||||
|
||||
if (!teamId) {
|
||||
throw new HTTPException(400, { message: 'Data corruption: Comment asset is not associated with a project' })
|
||||
throw new HTTPException(400, {
|
||||
message: 'Data corruption: Comment asset is not associated with a project',
|
||||
})
|
||||
}
|
||||
|
||||
const member = await this.prismaClient.teamMember.findUnique({
|
||||
@@ -1489,11 +1491,13 @@ export class AssetService {
|
||||
})
|
||||
|
||||
if (asset.storageKey) {
|
||||
await this.prismaClient.storageKey.delete({
|
||||
where: { id: asset.storageKey.id },
|
||||
}).catch(() => {
|
||||
// Silently ignore if already deleted
|
||||
})
|
||||
await this.prismaClient.storageKey
|
||||
.delete({
|
||||
where: { id: asset.storageKey.id },
|
||||
})
|
||||
.catch(() => {
|
||||
// Silently ignore if already deleted
|
||||
})
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
@@ -156,12 +156,28 @@ export function CompareViewer({
|
||||
activeEl &&
|
||||
(activeEl.tagName === 'INPUT' ||
|
||||
activeEl.tagName === 'TEXTAREA' ||
|
||||
activeEl.hasAttribute('contenteditable') ||
|
||||
activeEl.getAttribute('contenteditable') === 'true')
|
||||
(activeEl instanceof HTMLElement && activeEl.isContentEditable))
|
||||
) {
|
||||
return
|
||||
}
|
||||
|
||||
const isSpace = e.key === ' '
|
||||
const isInteractive =
|
||||
activeEl &&
|
||||
(activeEl.tagName === 'BUTTON' ||
|
||||
activeEl.tagName === 'A' ||
|
||||
activeEl.tagName === 'SELECT' ||
|
||||
activeEl.tagName === 'OPTION' ||
|
||||
activeEl.getAttribute('role') === 'button' ||
|
||||
activeEl.getAttribute('role') === 'link' ||
|
||||
activeEl.getAttribute('role') === 'checkbox' ||
|
||||
activeEl.getAttribute('role') === 'radio' ||
|
||||
activeEl.getAttribute('role') === 'menuitem')
|
||||
|
||||
if (isSpace && isInteractive) {
|
||||
return
|
||||
}
|
||||
|
||||
if (e.key === ' ' || e.key.toLowerCase() === 'k') {
|
||||
e.preventDefault()
|
||||
handleTogglePlay()
|
||||
|
||||
@@ -420,12 +420,28 @@ const VideoViewer = React.forwardRef<MediaController, FileViewerProps>(
|
||||
activeEl &&
|
||||
(activeEl.tagName === 'INPUT' ||
|
||||
activeEl.tagName === 'TEXTAREA' ||
|
||||
activeEl.hasAttribute('contenteditable') ||
|
||||
activeEl.getAttribute('contenteditable') === 'true')
|
||||
(activeEl instanceof HTMLElement && activeEl.isContentEditable))
|
||||
) {
|
||||
return
|
||||
}
|
||||
|
||||
const isSpace = e.key === ' '
|
||||
const isInteractive =
|
||||
activeEl &&
|
||||
(activeEl.tagName === 'BUTTON' ||
|
||||
activeEl.tagName === 'A' ||
|
||||
activeEl.tagName === 'SELECT' ||
|
||||
activeEl.tagName === 'OPTION' ||
|
||||
activeEl.getAttribute('role') === 'button' ||
|
||||
activeEl.getAttribute('role') === 'link' ||
|
||||
activeEl.getAttribute('role') === 'checkbox' ||
|
||||
activeEl.getAttribute('role') === 'radio' ||
|
||||
activeEl.getAttribute('role') === 'menuitem')
|
||||
|
||||
if (isSpace && isInteractive) {
|
||||
return
|
||||
}
|
||||
|
||||
if (e.key === ' ' || e.key.toLowerCase() === 'k') {
|
||||
e.preventDefault()
|
||||
togglePlay()
|
||||
|
||||
Reference in New Issue
Block a user