Commit Graph
1153 Commits
Author SHA1 Message Date
yiling bb9c53adad feat(agent): clarify create_file tool usage and context hint instructions 2026-08-05 12:01:04 +08:00
Yiling-J 29161f3a1a Merge pull request #264 from shumaiOne/feat/autofill-context
feat(agent): propagate autofill context from chat to autofill workflow
2026-08-05 11:25:04 +08:00
yiling b806b0e2ba refactor(agent): drop field/option ids from list_autofill_fields results 2026-08-05 11:02:25 +08:00
yiling 033652cde3 feat(agent): propagate autofill context from chat to autofill workflow
Add an optional 'context' parameter to the create_file and create_version
agent tools so the chat agent can pass generation/source context (e.g.
'Generated using gemini') to the AI metadata autofill workflow.

- Add Asset.autofillContext column, persisted in the same transaction as
  asset creation when context is provided
- Add new list_autofill_fields agent tool exposing autofillable metadata
  fields (name, type, description, options) per project
- Autofill workflow reads the stored context and includes it in the
  autofill AI prompt
- Add short chat system-prompt guidance to use list_autofill_fields and
  pass <=50 word context when creating files/versions
2026-08-05 10:33:02 +08:00
Yiling-J 30021b07d0 Merge pull request #263 from shumaiOne/feat/agent-create-file-from-content
feat(agent): allow create_file tool to create files directly from content
2026-08-04 21:50:19 +08:00
yiling 07ad0d2f65 feat(agent): allow create_file tool to create files directly from content
Add an optional 'data' field ({name, content}) to the create_file agent tool
so agents can create files without a local file (e.g. when bash is not
available). The existing 'path' upload mode is preserved; exactly one of
'path' or 'data' must be provided.

Extract mime detection helpers (getFileMimeType, readFileMimeType) into a
new file-mime module, keeping utils/mime.ts free of fs/path imports so it
stays compatible with the Temporal workflow bundle (agent-autofill imports
getProxyType from it). Refactor create_version to reuse the extracted
helpers.

Content uploads reuse s3Service.putObject; mime type is derived from the
filename extension with a text/plain fallback, and the name is sanitized
for the S3 key.
2026-08-04 21:16:33 +08:00
Yiling-J 5ef763fbae Merge pull request #262 from shumaiOne/feat/agent-bash-restriction-for-non-owners
feat(agent): restrict bash access for non-owner users
2026-08-04 18:21:22 +08:00
yiling e6fde25446 fix(agent): activate bash tool after skill load and fix chat stream
Two bugs found while testing skill loading as a non-owner:

1. The injected bash tool was never actually usable: AgentHarness.setTools
   only updates the tool registry unless activeToolNames is passed, so bash
   was missing from the active tool set sent to the model on the next turn.
   Pass the full post-update tool list as activeToolNames.

2. The active_tools_change session entry (written by setTools) has no chat
   representation, so mapEntryToMessage fell back to fabricating an empty
   user message that appeared as a stray empty bubble in the chat stream.
   Render active_tools_change as a typed custom message and skip entry
   types that have no chat representation instead of emitting empty text.
2026-08-04 17:01:47 +08:00
yiling dd2f8e68d9 fix(agent): fail closed when user role cannot be resolved
A userId that is not a team member previously resolved to isOwner=true
(role === undefined || role === 'owner'), bypassing bash restrictions.
Treat only flows without a user context (autofill etc.) and explicit
owner memberships as unrestricted; unknown users are now restricted.
2026-08-04 16:26:16 +08:00
yiling c938e84ccc feat(agent): restrict bash access for non-owner users
Editor/reviewer users can no longer ask the agent to run arbitrary bash
commands. Bash execution for them is gated behind approved team skills:

- Add required source param (enum user/skill) to the bash tool; commands
  with source=user are blocked when the user is not a team owner.
- Append a Restricted User Context instruction to the system prompt for
  non-owner users: never run user-requested bash, only skill-required
  commands with source=skill.
- Delay bash tool injection for editor/reviewer: it is only added after
  a skill is successfully loaded via read_skill (or restored when a
  skill was loaded earlier in the session). Team owners are unaffected.
2026-08-04 16:08:04 +08:00
Yiling-J 9745985f57 Merge pull request #261 from shumaiOne/feat/e2e-search-file-list
test(e2e): add search in file list and save-search-as-collection cases
2026-08-04 15:11:37 +08:00
yiling b645a29608 test(e2e): add search in file list and save-search-as-collection cases 2026-08-04 14:52:24 +08:00
Yiling-J deeb02351f Merge pull request #260 from shumaiOne/feat/e2e-file-domain-comments
feat(e2e): add file domain comment and draw tests
2026-08-04 11:25:01 +08:00
yiling c53919b891 ci: add system dependencies installation to app E2E CI job 2026-08-04 11:17:16 +08:00
yiling edf1f6a327 feat(e2e): add file domain comment and draw tests 2026-08-04 10:59:31 +08:00
Yiling-J 1afdbb671b Merge pull request #259 from shumaiOne/feat/project-e2e-tests
test(e2e): add project-level invite and file-move e2e tests
2026-08-03 18:33:48 +08:00
yiling 134d19d907 test(e2e): add project-level invite and file-move e2e tests
Add four project-level webapp e2e tests:
- invite a member to a project; the invitee only sees the invited project
- drag a file into a folder and a folder into another folder
- drag a file onto a file to create a version stack
- drag a file onto a version stack to add a new version

Supporting changes:
- expose rootFolderId on the project fixture
- add seedFolder/seedFile helpers and a cross-browser dragCard helper
  (WebKit requires pointer moves in awaited batches for dnd-kit activation)
- add project-members-trigger testid to the file-browser toolbar
- document the new test cases in the e2e README
2026-08-03 18:04:19 +08:00
yiling 043cde9fcc update agentsmd 2026-08-03 17:09:46 +08:00
Yiling-J 472ffddc99 Merge pull request #258 from shumaiOne/feat/web-e2e-file-share-collection
test(e2e): add file, share, and collection web app e2e tests
2026-08-03 17:07:08 +08:00
yiling 78eb840bf5 test(e2e): upload a 5px png instead of txt to avoid slow transcode 2026-08-03 16:45:38 +08:00
yiling 077536de98 test(e2e): move invite-member spec to the team domain 2026-08-03 16:39:51 +08:00
yiling 3789366d35 test(e2e): add file, share, and collection web app e2e tests
Add six domain-level web app e2e tests covering team member removal,
file upload/delete/restore, share link creation and password protection,
and collection creation. Introduce a parametrized 'file' fixture with
configurable media types (text/binary/image/video/pdf) for future
type-scoped tests, plus helpers for share APIs and team member seeding.

Also document all web app e2e test cases in apps/web/e2e/README.md and
require this documentation in AGENTS.md.
2026-08-03 16:34:37 +08:00
Yiling-J 5647231d7f Merge pull request #257 from shumaiOne/feat/e2e-domain-tests
test(e2e): add domain-based auth and project web app e2e tests
2026-08-03 15:42:32 +08:00
yiling b2a11c5ce9 docs: add Web App E2E Tests section to developer guide 2026-08-03 15:32:38 +08:00
yiling 4532deb753 test(e2e): add domain-based auth and project web app e2e tests 2026-08-03 15:24:21 +08:00
Yiling-J 6efa634f54 Merge pull request #256 from shumaiOne/fix/mention-popup-avatar-and-scroll
fix(webui): mention popup avatars, keyboard auto-scroll, and non-sticky section headers
2026-08-03 14:56:20 +08:00
yiling d696c39622 fix(webui): stop mention popup section headers from sticking and overlapping
Both Agents and Members header buttons had 'sticky top-0', so while
scrolling the 256px mention list the Agents header stayed pinned and the
Members header snapped to the same top position, covering it exactly.
Remove 'sticky top-0' so headers scroll away naturally with their
sections.
2026-08-03 14:47:43 +08:00
yiling 83d22d47a2 fix(webui): show member avatars and auto-scroll in mention popup
- Render real avatar images (with initials fallback) for users in the
  @-mention popup instead of a colored letter circle; bots keep the
  colored fallback since BotInfo has no image field.
- Auto-scroll the highlighted mention row into view when navigating
  the list with ArrowUp/ArrowDown keys.
2026-08-03 14:38:40 +08:00
Yiling-J 4436c3304d Merge pull request #255 from shumaiOne/refactor/use-pi-builtin-providers
refactor(core): replace generated provider files with pi-ai dynamic methods
2026-08-03 11:43:38 +08:00
yiling 2fee708863 feat(agent): implement DatabaseSessionStorage getSessionName and getSessionStats methods 2026-08-03 10:40:33 +08:00
yiling dbe3420b6c feat(agent): update pi packages to 0.82.1 and implement new SessionStorage interface methods 2026-08-03 10:25:10 +08:00
yiling 16d136b45a refactor(core): replace generated provider files with pi-ai dynamic methods 2026-08-03 10:00:21 +08:00
Yiling-J 2656a42c86 Merge pull request #254 from shumaiOne/feat/agent-preference-localstorage
feat(webui): persist agent preference in localStorage
2026-08-02 15:31:00 +08:00
yiling 15910a0bf4 feat(webui): persist agent preference in localStorage 2026-08-02 15:06:51 +08:00
Yiling-J 5458189c1f Merge pull request #253 from shumaiOne/refactor/replace-deprecated-get-model
refactor(agent): load models directly from database without pi fallback
2026-08-02 14:36:54 +08:00
yiling d3aef5f0c1 fix(agent): add required api field to test mock provider config 2026-08-02 14:30:28 +08:00
yiling 5946a679ea refactor(agent): load models directly from database without pi fallback 2026-08-02 14:26:03 +08:00
yiling a54c04e15a update providers 2026-08-01 21:38:42 +08:00
Yiling-J 0bccd13399 Merge pull request #252 from shumaiOne/test/add-missing-core-service-tests
test(core): add missing tests for methods introduced in 97069042
2026-08-01 20:58:15 +08:00
yiling 3b86d9b6d8 test(core): add missing tests for methods introduced in 97069042
Add comprehensive test coverage for 5 core service methods that were
added in the layered architecture refactor but lacked tests:

- AgentService.getAgent: found/not-found cases
- ProjectService.getUserProjects: team scope, project scope,
  multi-team aggregation, limit, and empty result cases
- SkillService.getSkill: full field mapping and not-found cases
- TeamService.hasWritableRoleInAnyTeam: owner, editor, reviewer,
  and no-membership cases
- UserService (new file): getUserById and createGuestUser
2026-08-01 20:44:34 +08:00
Yiling-J 1600949e4a Merge pull request #251 from shumaiOne/feat/audit-log-support
feat(audit): add audit log support for APIs and WebUI dashboard
2026-08-01 19:19:20 +08:00
yiling 2f5b968935 fix(api): fix eslint any type assertion in file.test.ts 2026-08-01 16:35:57 +08:00
yiling 97069042b2 refactor(api): enforce layered architecture by moving db queries to core services 2026-08-01 16:25:01 +08:00
yiling fb66166b49 feat(core): wrap audit log creation in try catch to prevent blocking APIs 2026-08-01 15:50:35 +08:00
yiling b0d8ecb589 refactor(dtos): define AuditAction enum in dtos package to decouple from db 2026-08-01 15:28:23 +08:00
yiling 2d61fae699 refactor(db): consolidate audit log migration into single add_audit_log migration 2026-08-01 15:19:53 +08:00
yiling 5ef7716c9c feat(audit): change audit log action to string at db level and split file/folder actions 2026-08-01 14:49:08 +08:00
yiling 6d80f06c22 refactor(core): update getAssetContext to throw error on missing asset 2026-08-01 11:21:56 +08:00
yiling 0324b95c7e feat(api): add missing audit log calls to API endpoints 2026-08-01 11:03:50 +08:00
yiling 7dfb2c7f2f refactor(dtos): use @shumai/db/enums across DTO definitions 2026-08-01 10:47:41 +08:00