Commit Graph
188 Commits
Author SHA1 Message Date
yiling ffc578cb45 fix(comments): prevent reload of main viewer by invalidating only comments queries 2026-07-06 12:51:25 +08:00
yiling a312ecf7ef style(comments): use custom filled circle check icon and make actions row always visible 2026-07-06 12:40:20 +08:00
yiling e1d3dd46db feat(comments): allow marking comments as complete or incomplete 2026-07-06 12:24:40 +08:00
yiling 01a9c7cde6 refactor(i18n): address code review feedback on string legos, hardcoded locales, and fragile checks 2026-07-06 10:52:55 +08:00
yiling 45f3255796 feat(i18n): localize members dialog, notifications, uploads, user menus, dates, and players 2026-07-06 10:38:41 +08:00
yiling cee4142936 style(webui): use dark background for audio preview to keep duration clear 2026-07-05 16:16:04 +08:00
yiling 0f6912c977 feat(webui): render duration overlay for audio files in file browser 2026-07-05 16:13:00 +08:00
yiling 868e7b2a7b fix(webui): remount file viewer when file ID changes to reset state 2026-07-05 16:10:01 +08:00
yiling ccfcdce23c fix(upload): correct .wma MIME type to audio prefix on upload and add tests 2026-07-05 15:57:29 +08:00
yiling e511af219e fix(webui): immediately use currentTime fallback in useFramePlayer for audio files 2026-07-05 15:23:52 +08:00
yiling 5cae1adce1 fix(webui): hide zoom/fit controls and comment draw button for audio assets 2026-07-05 15:19:53 +08:00
yiling a2e982f2e6 feat(transcode): add audio file support with AAC stereo mp4 proxy and styled viewer 2026-07-05 15:11:19 +08:00
yiling 1524d41392 fix(webui): resolve react hook order violation in video viewer 2026-07-05 12:04:35 +08:00
yiling 4cc35d3453 refactor(webui): modularize file viewer components into registry-driven architecture 2026-07-05 10:51:42 +08:00
yiling 175b5ac171 fix(webui): resolve video player total frames mismatch
Avoid deriving total frames from container duration when the audio tail mismatch is below the dynamic playback stall threshold. This prevents the rendering of phantom trailing frames that the playhead cannot reach during playback.

Also adds comprehensive unit and E2E tests covering both small and large audio tail gaps.
2026-07-04 16:44:09 +08:00
yiling ba88cdad78 fix(webui): sync compare video pane resolution/source on asset change
currentResolution state and currentSrcRef were only initialized on mount,
so if file.id changed without a remount the video.js init effect (keyed on
file.id) would re-create the player with a stale source. Add an effect
that resets them when file.id changes, before the init effect runs, making
the pane robust even without a per-asset key on the parent.
2026-07-04 15:29:07 +08:00
yiling 0bbb846beb fix(webui): support version switching on public share (no login redirect)
Switching a version in the public share breadcrumb navigated to the
authenticated /projects/:id/files/:id route, which triggered the
authenticated /api/projects/:id/team call (via resolveTeamIdFromPath) ->
401 -> redirect to login.

- breadcrumb handleVersionClick now routes to /share/:shareId/files/:id
  with a version search param when public.
- public share route gains a version param; PublicShareManager fetches the
  stack asset (for the version list) and the active version child asset
  (for display/comments/fields), mirroring the authenticated page.
- compare exit sets version to the active side for parity.
2026-07-04 15:22:38 +08:00
yiling c793e0dd78 fix(webui): keep fullscreen controls visible while cursor is over them
Track when the cursor is over the control bar (VideoControlBar now
forwards mouse enter/leave) and skip the idle-hide timer while it is, so
the bar no longer disappears when the cursor rests on it. Also reduce the
fullscreen auto-hide delay from 2s to 1.2s.
2026-07-04 13:15:52 +08:00
yiling 13833e8144 fix(webui): auto-hide fullscreen controls on idle regardless of play state
The fullscreen control bar only auto-hid while playing, and a separate
effect force-showed it whenever paused, so it stayed visible permanently
when paused in fullscreen. Now in fullscreen the bar shows on cursor move
and hides after the cursor is idle (~2s) whether playing or paused;
windowed mode keeps the bar always visible.
2026-07-04 13:04:25 +08:00
yiling d3c1c641b4 fix(webui): show control bar in single-file fullscreen; theme the overlay
The single-file player fullscreened the inner video-area element, which
is not an ancestor of the control bar, so the bar was never visible in
fullscreen. Fullscreen the player root instead so the floating control
bar is included and the existing show-on-move / hide-after-idle logic
works (YouTube-style).

Also make the control-bar colors theme-aware in all cases. The fullscreen
floating overlay now uses bg-card/90 + backdrop-blur + foreground text
instead of a hardcoded dark overlay, so it follows the app light/dark
theme. The former themedChrome prop is renamed to floatOverlayInFullScreen
(default true = single-file floating overlay; compare passes false to keep
its bar in-flow).
2026-07-04 12:48:15 +08:00
yiling aeaff3bc88 feat(webui): compare fullscreen control bar follows app theme
Add a themedChrome prop to VideoControlBar that keeps the normal
theme-aware chrome (bg-card / foreground text) while fullscreen instead
of the dark video overlay. Compare mode passes it so its fullscreen bar
matches the app light/dark theme for both video- and image-active panes
(ImageControlBar is already themed). The single-file player is unchanged
(themedChrome defaults to false -> dark overlay). The fullscreen toggle
icon still reflects the actual fullscreen state.
2026-07-04 12:28:08 +08:00
yiling cf005797be fix(webui): readable zoom/Fit controls in fullscreen light mode
In the fullscreen control bar the whole bar uses text-white (it overlays
the dark video), but the zoom group and Fit button hardcoded bg-muted,
which is light in light mode -> white text on a light background. Use a
translucent bg-white/15 for those controls when fullscreen so they stay
readable; the normal (non-fullscreen) bar keeps bg-muted. Also fixes the
same latent issue in the single-file video player.
2026-07-04 11:36:04 +08:00
yiling 4b3b31c83d style(webui): compare pane topbar is always dark with light text
Force the dark palette on the compare pane topbar (via a scoped `dark`
class + system tokens, no hardcoded hex) so the bar background is dark in
both light and dark app themes. Active pane text uses text-foreground
(white in the dark scope); inactive pane uses text-muted-foreground
(light gray).
2026-07-04 11:25:39 +08:00
yiling a4e25db0f7 style(webui): emphasize active compare pane topbar
The active version's topbar now uses an inverted bar (bg-foreground /
text-background) so it reads as black background with white text in the
light theme, while the inactive pane keeps the card background with muted
text. Filename/version text color now differs between active and inactive
panes.
2026-07-04 11:19:50 +08:00
yiling 78c8a56183 fix(webui): clicking an inactive compare pane only activates it
Previously clicking a non-active video pane both switched the active
version and toggled playback. Now a click on an inactive pane only makes
it active; play/pause is only toggled when clicking the already-active
pane.
2026-07-04 10:56:55 +08:00
yiling e2d4944060 refactor(webui): extract shared Video/Image control bars and reuse in compare
Extract the video player's inline ControlBar into an exported
viewers/video-control-bar.tsx (VideoControlBar + PlayerState +
DisplayTranscode) and the image toolbar from file-viewer into an exported
viewers/image-control-bar.tsx (ImageControlBar). video-player and
file-viewer now consume the shared components with unchanged behavior.

compare-control-bar composes the same two shared bars (video vs image
active) with fan-out handlers, so the compare control bar can no longer
drift from the single-file players (e.g. the time-format dropdown).
2026-07-04 10:49:00 +08:00
yiling 6c3d3ea2b3 feat(webui): add compare versions view for version stacks
Add a Compare Versions mode to the file detail page (authenticated and
public share) that splits the viewer into two 50/50 panes showing two
versions side by side.

- Breadcrumb file menu gains a Compare Versions entry (version stacks
  with >=2 versions); the file segment is hidden in compare mode.
- URL-driven state (compare/cmpLeft/cmpRight/cmpActive) on both file
  routes so the view is refresh/share-safe.
- Per-side topbar with filename, version, version-switch dropdown, an
  active-side highlight, and an X exit button.
- Shared control bar reflects the active pane; for same-type media it
  coordinates both panes (play/pause, seek, frame-step, zoom, pan sync),
  seekbar length matches the active side while the shorter side holds its
  last frame; only the active side plays audio; resolution/download apply
  to the active side; fullscreen covers the whole compare view.
- Right sidebar (comments/fields) binds to the active side; comment
  selection seeks the active pane and annotations/comments can be created.
- Reuses useFramePlayer + DrawingCanvas without modifying the existing
  single-file video player.
- Unit tests for compare selection/clamp logic.
2026-07-04 10:20:16 +08:00
yiling d3efc00902 feat(file-browser): show video duration on file card preview
Display the video duration (mm:ss) in the bottom-right corner of the
video file card preview area with white text and a transparent
background. Duration is sourced from media metadata and exposed via the
preview DTO. The overlay is gated behind a showDuration prop so it only
appears on file cards, not folder card child previews.
2026-07-03 20:48:26 +08:00
yiling 9623da7504 fix(webui): resolve conditional hooks and setState-in-render errors
- __root.tsx: move useTeamContextStore/useEffect/useQuery above the
  conditional 'return <Outlet />' so hooks run unconditionally in a
  stable order (fixes 'Rendered more hooks than during the previous
  render')
- team-selector.tsx: move single-team navigate() into a useEffect to
  avoid updating the router Transitioner during render
2026-07-03 18:53:38 +08:00
yiling 38694eb77b fix(webui): stop Safari video playhead from rewinding on play/pause
On Safari/WebKit, video.currentTime (the playback clock) runs ahead of the
frame actually presented on screen at playback start, and the first
requestVideoFrameCallback arrives only after a delay. useFramePlayer drove the
playhead from currentTime immediately on play, racing it forward, then snapped
it backward when the first rVFC reported the true (lower) presented frame.

Fix 1 (play-start rewind): reset the per-session VFC state on each play and only
use the currentTime/RAF path when rVFC is unsupported, or has delivered a frame
this session and then stalled (e.g. video track ended while audio continues), or
never delivered within a safety grace. The playhead now follows the actually
presented frame instead of the leading playback clock.

Fix 2 (pause snap): on pause, prefer the last presented mediaTime when rVFC is
fresh so the playhead locks to the frame the user is looking at, instead of
jumping forward to the leading currentTime. Falls back to currentTime when rVFC
is stale/unsupported.

Add a deterministic useFramePlayer hook unit test (happy-dom) that simulates
Safari's leading currentTime and lagging mediaTime; it asserts the playhead is
monotonic on play and locks to the presented frame on pause (both fail on the
old logic), and that the end-of-track currentTime fallback still works.
2026-07-03 15:56:31 +08:00
yiling 469f68b25d test(webui): add playwright e2e framework with video player play/pause test
Add a Playwright UI integration test framework for the frame-accurate video
player. Tests run against a backend-free harness served by Bun's native HTML
bundler (matching the project's Bun-based dev/prod serving), so no database,
auth or transcode pipeline is required.

- Add @playwright/test with chromium/firefox/webkit projects; the browser is
  selectable via the Playwright --project flag (webkit = Safari engine).
- Serve the harness with Bun.serve + bun-plugin-tailwind (no separate Vite
  toolchain); commit a deterministic 16x16/5s/30fps fixture video and matching
  AssetInfo.
- Add a play/pause spec covering both the play control and clicking the video
  area, asserting the native video clock, seekbar fill and frame readout stay
  frame-locked after pause (settle-aware, tolerance-based assertions).
- Mock all backend API calls (anchored /api/ and /files/ routes) for isolation.
- Exclude e2e specs from Vitest; add a separate CI job (webkit on macOS).
2026-07-03 14:50:38 +08:00
yiling b7367bb129 refactor(storage): use original filenames and fix download UX
- Store uploaded files as files/{ulid}/{original-name} instead of files/{ulid}/raw
- Store transcoded videos as {stem}-{resolution}.mp4 (e.g. foo-720p.mp4)
- Store transcoded images as {stem}-{width}p.webp (e.g. foo-1920p.webp)
- Add download?: boolean param to presign - only sets Content-Disposition: attachment when true
- Local storage handler only sets Content-Disposition when ?download=1 query param is present
- Add POST /api/files/download-url endpoint for key-based single file downloads
  - Uses ResourceType.Asset for permission check
  - Validates key belongs to the asset's storage directory
- Fix existing download-links API to pass download: true to presign
- Fix breadcrumb navbar download: video shows resolution submenu, others download directly
- Fix video player download: calls download-url API, shows correct file type label
- Remove filename query param hack from presign URLs
- Add sanitizeFilename() and stemFromKey() utility helpers
- Add key field to VideoTranscode DTO interface
2026-07-02 17:39:23 +08:00
yiling d0bda60b9f fix(webui): preserve video ended state by skipping playhead snap on ended 2026-07-01 14:46:12 +08:00
yiling d71b0de056 remove video player debug logs 2026-07-01 14:37:34 +08:00
yiling 899b600417 fix(webui): resolve 1-frame comment mismatch via 0.45 offset and pause snapping 2026-06-30 11:10:53 +08:00
yiling 86ad68a705 feat(webui): add Fit zoom button in video player control bar 2026-06-30 10:50:30 +08:00
yiling d2ee7f1c45 fix(webui): prevent initial scale fit layout race condition 2026-06-30 10:45:51 +08:00
yiling 1704fddc67 refactor(webui): use Floor with Epsilon (0.001) for frame conversion calculations 2026-06-30 10:22:32 +08:00
yiling 07d82377bd fix(webui): implement dynamic stall threshold for requestVideoFrameCallback 2026-06-30 09:47:13 +08:00
yiling 9c8f29e3ba fix(webui): unify playhead loop with requestAnimationFrame to prevent deadlock 2026-06-29 20:33:24 +08:00
yiling 9fd707b23f fix(webui): fallback to requestAnimationFrame when video track freezes 2026-06-29 20:16:06 +08:00
yiling 14f6752de2 fix(webui): align video timeline duration and formatting with frameio 2026-06-29 19:48:28 +08:00
yiling 95f91cd4de feat(db): add custom migration to backfill totalFrames and startTimecode 2026-06-29 11:27:32 +08:00
yiling bb65c5a0d3 perf(video): optimize keydown listener binding in useFramePlayer 2026-06-29 11:01:10 +08:00
yiling a585718660 fix(video): add fallback timeout to seeked Promise wrapper to prevent permanent freeze 2026-06-29 10:58:34 +08:00
yiling 9ca9b2d8e4 fix(video): safely sync startTime seek with VideoJS loadedmetadata status 2026-06-29 10:53:14 +08:00
yiling b173b4910e test(video): extract calculateFrameCenterTime helper and add unit tests 2026-06-29 10:10:47 +08:00
yiling 9576453a72 fix(video): display totalFrames - 1 as duration to align timer at end 2026-06-29 10:02:17 +08:00
yiling 5233615720 fix(video): add centralized playhead nudge for boundary-accurate seeking 2026-06-28 23:22:03 +08:00
yiling 1ebf79edd3 fix(video): resolve 1-frame shift on external seeks due to floor rounding 2026-06-28 21:12:29 +08:00